ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc - Issue 302463004: Implementing the dispatch of the swipe gesture for one-finger touch swipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc

Issue 302463004: Implementing the dispatch of the swipe gesture for one-finger touch swipes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implementing review feedback. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc

diff --git a/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc b/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc

index 5ca210a07e3c88a5dfea5d1070fd25c0be995575..9e389bfa14cefb09f919f1e0fe07c309a06fb67d 100644

--- a/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc

+++ b/ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc

@@ -996,10 +996,10 @@ TEST_F(TouchDispositionGestureFilterTest, TestAllowedMultiFingerSwipe) {

EXPECT_TRUE(GesturesMatch(Gestures(ET_GESTURE_PINCH_BEGIN),

GetAndResetSentGestures()));

- PushGesture(ET_GESTURE_MULTIFINGER_SWIPE);

+ PushGesture(ET_GESTURE_SWIPE);

PressTouchPoint(1, 1);

SendTouchNotConsumedAck();

- EXPECT_TRUE(GesturesMatch(Gestures(ET_GESTURE_MULTIFINGER_SWIPE),

+ EXPECT_TRUE(GesturesMatch(Gestures(ET_GESTURE_SWIPE),

GetAndResetSentGestures()));

}

@@ -1018,7 +1018,7 @@ TEST_F(TouchDispositionGestureFilterTest, TestDisallowedMultiFingerSwipe) {

SendTouchNotConsumedAck();

EXPECT_FALSE(GesturesSent());

- PushGesture(ET_GESTURE_MULTIFINGER_SWIPE);

+ PushGesture(ET_GESTURE_SWIPE);

PressTouchPoint(1, 1);

SendTouchNotConsumedAck();

EXPECT_FALSE(GesturesSent());

« no previous file with comments | « ui/events/gesture_detection/touch_disposition_gesture_filter.cc ('k') | ui/events/gesture_event_details.h » ('j') | no next file with comments »