ash/wm/toplevel_window_event_handler.cc - Issue 302463004: Implementing the dispatch of the swipe gesture for one-finger touch swipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/toplevel_window_event_handler.cc

Issue 302463004: Implementing the dispatch of the swipe gesture for one-finger touch swipes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing review feedback and also rebasing to resolve conflicts. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/touch/touch_uma.cc ('K') | « ash/wm/gestures/overview_gesture_handler.cc ('k') | content/browser/renderer_host/ui_events_helper.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/toplevel_window_event_handler.cc

diff --git a/ash/wm/toplevel_window_event_handler.cc b/ash/wm/toplevel_window_event_handler.cc

index f20a13fc7dd2b90e8601a284defbc3a6d5236783..40cb3958aa71f6f81d838487486f5fe20bfdfdaf 100644

--- a/ash/wm/toplevel_window_event_handler.cc

+++ b/ash/wm/toplevel_window_event_handler.cc

@@ -344,7 +344,10 @@ void ToplevelWindowEventHandler::OnGestureEvent(ui::GestureEvent* event) {

}

event->StopPropagation();

return;

- case ui::ET_GESTURE_MULTIFINGER_SWIPE:

+ case ui::ET_GESTURE_SWIPE:

+ DCHECK(event->details().touch_points() > 0);

sky 2014/05/27 17:27:54 DCHECK_GT

mfomitchev 2014/05/27 18:33:43 Done.

+ if (event->details().touch_points() == 1)

+ return;

if (!wm::GetWindowState(target)->IsNormalOrSnapped())

return;

« ash/touch/touch_uma.cc ('K') | « ash/wm/gestures/overview_gesture_handler.cc ('k') | content/browser/renderer_host/ui_events_helper.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')