Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: content/browser/media/android/browser_media_player_manager.h

Issue 302453012: Support casting for embedded YT videos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merged parameters into struct to avoid 2 IPC calls, updated nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.h
diff --git a/content/browser/media/android/browser_media_player_manager.h b/content/browser/media/android/browser_media_player_manager.h
index b6648f0f6ba0283e1f7b22d9115d932ed3cd1bf3..78e7a6a73538e1cc71a2fd0c5f3cd626c20bcb87 100644
--- a/content/browser/media/android/browser_media_player_manager.h
+++ b/content/browser/media/android/browser_media_player_manager.h
@@ -29,6 +29,8 @@ class DemuxerAndroid;
class MediaKeys;
}
+struct MediaPlayerHostMsg_Initialize_Params;
+
namespace content {
class BrowserDemuxerAndroid;
class ContentViewCoreImpl;
@@ -122,10 +124,7 @@ class CONTENT_EXPORT BrowserMediaPlayerManager
virtual void OnExitFullscreen(int player_id);
virtual void OnInitialize(
MediaPlayerHostMsg_Initialize_Type type,
acolwell GONE FROM CHROMIUM 2014/06/09 20:02:09 nit: Any reason why this can't go in the params st
May 2014/06/10 18:22:19 No real reason, just preference. merged it in the
- int player_id,
- const GURL& url,
- const GURL& first_party_for_cookies,
- int demuxer_client_id);
+ const MediaPlayerHostMsg_Initialize_Params& media_player_params);
virtual void OnStart(int player_id);
virtual void OnSeek(int player_id, const base::TimeDelta& time);
virtual void OnPause(int player_id, bool is_media_related_action);

Powered by Google App Engine
This is Rietveld 408576698