Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 302453004: Move linker settings from standalone.gypi to pdfium.gyp, since they're needed when linking pdfium_t… (Closed)

Created:
6 years, 7 months ago by jam
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Move linker settings from standalone.gypi to pdfium.gyp, since they're needed when linking pdfium_test as part of other projects' gyp files as well where standalone.gypi isn't used. R=scottmg@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/75392b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M build/standalone.gypi View 2 chunks +0 lines, -11 lines 0 comments Download
M pdfium.gyp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
6 years, 7 months ago (2014-05-25 15:26:45 UTC) #1
scottmg
6 years, 7 months ago (2014-05-26 16:25:24 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698