Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 302443012: add a verbose flag to skdiff that shows the progress and status of (Closed)

Created:
6 years, 6 months ago by humper
Modified:
6 years, 6 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

add a verbose flag to skdiff that shows the progress and status of each comparison BUG= Committed: http://code.google.com/p/skia/source/detail?r=14923

Patch Set 1 #

Patch Set 2 : remove __VA_ARGS__ macro thing; it's probably not portable and didn't use it hardly at all #

Total comments: 6

Patch Set 3 : address ben comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M tools/skdiff_main.cpp View 1 2 8 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
humper
ptal -- I hate always silent tools
6 years, 6 months ago (2014-05-28 17:04:46 UTC) #1
bungeman-skia
Seems like a nice idea. https://codereview.chromium.org/302443012/diff/20001/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.chromium.org/302443012/diff/20001/tools/skdiff_main.cpp#newcode319 tools/skdiff_main.cpp:319: #define VERBOSE_STATUS(status,color,filename) if (verbose) ...
6 years, 6 months ago (2014-05-28 17:34:27 UTC) #2
humper
https://codereview.chromium.org/302443012/diff/20001/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.chromium.org/302443012/diff/20001/tools/skdiff_main.cpp#newcode319 tools/skdiff_main.cpp:319: #define VERBOSE_STATUS(status,color,filename) if (verbose) printf( "[ " color " ...
6 years, 6 months ago (2014-05-28 17:55:31 UTC) #3
bungeman-skia
lgtm
6 years, 6 months ago (2014-05-28 18:01:43 UTC) #4
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-28 18:04:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/302443012/40001
6 years, 6 months ago (2014-05-28 18:04:49 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 18:26:01 UTC) #7
Message was sent while issue was closed.
Change committed as 14923

Powered by Google App Engine
This is Rietveld 408576698