ash/wm/maximize_mode/maximize_mode_window_state.cc - Issue 302443005: Kill animations on screen rotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/maximize_mode/maximize_mode_window_state.cc

Issue 302443005: Kill animations on screen rotation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabling animation at the source (MaximizeModeWindowState) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/maximize_mode/maximize_mode_window_state.cc

diff --git a/ash/wm/maximize_mode/maximize_mode_window_state.cc b/ash/wm/maximize_mode/maximize_mode_window_state.cc

index 5c6623b7716e40f0ac718c6114fec8e8e8e72436..888324d70c49bf65a2b7eac540e69b13538b5671 100644

--- a/ash/wm/maximize_mode/maximize_mode_window_state.cc

+++ b/ash/wm/maximize_mode/maximize_mode_window_state.cc

@@ -176,10 +176,13 @@ void MaximizeModeWindowState::OnWMEvent(wm::WindowState* window_state,

}

break;

case wm::WM_EVENT_WORKAREA_BOUNDS_CHANGED:

- case wm::WM_EVENT_DISPLAY_BOUNDS_CHANGED:

if (current_state_type_ != wm::WINDOW_STATE_TYPE_MINIMIZED)

UpdateBounds(window_state, true);

break;

+ case wm::WM_EVENT_DISPLAY_BOUNDS_CHANGED:

+ if (current_state_type_ != wm::WINDOW_STATE_TYPE_MINIMIZED)

+ UpdateBounds(window_state, false);

flackr 2014/05/26 21:42:36 Maybe add a quick comment as to why we don't want

+ break;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »