Kill animations on screen rotation.

Kill animations on screen rotation.

BUG=376038
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272906

[girard, 2014-05-26 05:04:35]

Not sure what to do on this one.... it looks like the changes in r272040 make
the current patch fail. Perhaps that's okay, since this patch is intended for
m36, which doesn't include r272040.

I could write a patch that works in M37, but then it won't be mergeable to M36.

[flackr, 2014-05-26 20:36:44]

CC +skuhne, do you know if something in MaximizeModeWindowManager is causing the
window animations when the display bounds change? We should be immediately
updating the sizes.

https://codereview.chromium.org/302443005/diff/1/ash/wm/maximize_mode/maximiz...
File ash/wm/maximize_mode/maximize_mode_controller.cc (right):

https://codereview.chromium.org/302443005/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_controller.cc:301: aura::Window*
window(Shell::GetPrimaryRootWindow());
Should get the internal display root window rather than the primary, and
generalize this to a helper method for setting rotation.

That being said, I'd prefer we find what is animating on a display update and
stop it from doing so. Since this seems to only happen in touchview I suspect,
directly or indirectly, that it's MaximizeModeWindowManager.

[girard, 2014-05-26 21:41:10]

Tracked down the responsible code. Disabled the animation at the source.

[flackr, 2014-05-26 21:42:35]

LGTM with nit.

https://codereview.chromium.org/302443005/diff/20001/ash/wm/maximize_mode/max...
File ash/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/302443005/diff/20001/ash/wm/maximize_mode/max...
ash/wm/maximize_mode/maximize_mode_window_state.cc:184:
UpdateBounds(window_state, false);
Maybe add a quick comment as to why we don't want to animate on a display bounds
changed.

[girard, 2014-05-26 21:48:44]

The CQ bit was checked by girard@chromium.org

[commit-bot: I haz the power, 2014-05-26 21:48:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/girard@chromium.org/302443005/40001

[commit-bot: I haz the power, 2014-05-27 01:08:12]

Change committed as 272906

[Mr4D (OOO till 08-26), 2014-05-27 14:37:25]

The MaximizeModeWindowState object will get a WM_EVENT_DISPLAY_BOUNDS_CHANGED
and/or WM_EVENT_WORK_AREA_BOUNDS_CHANGED event which will automatically
re-adjust the window size & position.

These re-adjustments are most likely to be animated. (The WindowState object is
trying to maintain maximize mode).

If you do not want animations there that state needs to somehow know that the
rotation animation is going on.