Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 302443002: content: Fix a typo in GN common/BUILD.gn file. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, scottmg
Visibility:
Public.

Description

content: Fix a typo in GN common/BUILD.gn file. I got this by change when I ran: $ gn gen out/Debug_gn --args='os="linux" cpu_arch="arm"' ERROR at //content/common/BUILD.gn:151:31: Undefined identifier if (cpu_arch != "arm" || !is_chromos) { ^--------- BUG=None TEST=above TBR=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
TBRing... Scott, fyi.
6 years, 7 months ago (2014-05-24 02:16:40 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-24 02:22:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/302443002/1
6 years, 7 months ago (2014-05-24 02:23:45 UTC) #3
brettw
lgtm
6 years, 7 months ago (2014-05-24 02:24:14 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 02:28:01 UTC) #5
Message was sent while issue was closed.
Change committed as 272685

Powered by Google App Engine
This is Rietveld 408576698