Issue 302433016: Remove virtualized isRoot/isChild from HTMLImport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302433016: Remove virtualized isRoot/isChild from HTMLImport. (Closed)

Created:
6 years, 6 months ago by dglazkov

Modified:
6 years, 6 months ago

Reviewers:
Hajime Morrita, gmorrita

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove virtualized isRoot/isChild from HTMLImport. We can just test root-ness by the absence of parent. No behavior changes, just plumbotron. R=morrita BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175223

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	Source/core/html/imports/HTMLImport.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/html/imports/HTMLImportChild.h	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Hajime Morrita

lgtm. This is a bit fragile because the function can be called before it is ...

6 years, 6 months ago (2014-05-28 20:31:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/302433016/1

6 years, 6 months ago (2014-06-01 15:11:02 UTC) #4

Message was sent while issue was closed.

Change committed as 175223