Source/core/html/HTMLElement.cpp - Issue 302433015: Use correct offset when attribute auto is present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 302433015: Use correct offset when attribute auto is present (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated tests to pass on mac and windows. Also a condition in HTMLElement which sets any direction … Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLElement.cpp

diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp

index 7d741fc5342614a92de9e35a0a1acfe0b8eed8c1..4c24e320fb7a2570c817cb4ed13d2f4f699f4515 100644

--- a/Source/core/html/HTMLElement.cpp

+++ b/Source/core/html/HTMLElement.cpp

@@ -753,7 +753,10 @@ void HTMLElement::calculateAndAdjustDirectionality()

{

Node* strongDirectionalityTextNode;

TextDirection textDirection = directionality(&strongDirectionalityTextNode);

- setHasDirAutoFlagRecursively(this, true, strongDirectionalityTextNode);

+ if (hasDirectionAuto())

+ setHasDirAutoFlagRecursively(this, true, strongDirectionalityTextNode);

+ else

+ setHasDirAutoFlagRecursively(this, false, strongDirectionalityTextNode);

if (renderer() && renderer()->style() && renderer()->style()->direction() != textDirection)

setNeedsStyleRecalc(SubtreeStyleChange);

}

« Source/core/dom/Position.cpp ('K') | « Source/core/dom/Position.cpp ('k') | no next file » | no next file with comments »