Use correct offset when attribute auto is present

Source/core/dom/Position.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 61 matching lines @@
         if (!renderer)
             continue;
         if (!node->rendererIsEditable())
             continue;
         if ((renderer->isBox() && toRenderBox(renderer)->inlineBoxWrapper()) || (renderer->isText() && toRenderText(renderer)->firstTextBox()))
             return node;
     }
     return 0;
 }
 
+static bool isTextDirectionHasAutoAttribute(Node *node)

[Inactive, 2014/06/02 15:15:08]

nit: star on wrong side.
nit: "isTextDirectionHasAutoAttribute" does not sound correct. We should
probably find a better name?

[Habib Virji, 2014/06/02 15:23:52]

Done.

+{
+    bool isAuto = node->selfOrAncestorHasDirAutoAttribute();
+    if (node->isInShadowTree()) {

[Inactive, 2014/06/02 15:15:08]

nit: No need for curly brackets.

[Habib Virji, 2014/06/02 15:23:52]

Done.

+        isAuto = equalIgnoringCase(node->shadowHost()->fastGetAttribute(dirAttr), "auto");
+    }
+    return isAuto;
+}
+
 Position::Position(PassRefPtrWillBeRawPtr<Node> anchorNode, LegacyEditingOffset offset)
     : m_anchorNode(anchorNode)
     , m_offset(offset.value())
     , m_anchorType(anchorTypeForLegacyEditingPosition(m_anchorNode.get(), m_offset))
     , m_isLegacyEditingPosition(true)
 {
     ASSERT(!m_anchorNode || !m_anchorNode->isPseudoElement());
 }
 
 Position::Position(PassRefPtrWillBeRawPtr<Node> anchorNode, AnchorType anchorType)
@@ skipping 1161 matching lines @@
         }
     } else {
         InlineBox* nextBox = inlineBox->nextLeafChildIgnoringLineBreak();
         if (!nextBox || nextBox->bidiLevel() < level) {
             // Right edge of a secondary run. Set to the left edge of the entire run.
             while (InlineBox* prevBox = inlineBox->prevLeafChildIgnoringLineBreak()) {
                 if (prevBox->bidiLevel() < level)
                     break;
                 inlineBox = prevBox;
             }
-            caretOffset = inlineBox->caretLeftmostOffset();
+            if (isTextDirectionHasAutoAttribute(m_anchorNode.get()))
+                caretOffset = (inlineBox->bidiLevel() < level) ? inlineBox->caretLeftmostOffset() : inlineBox->caretRightmostOffset();
+            else
+                caretOffset = inlineBox->caretLeftmostOffset();
         } else if (nextBox->bidiLevel() > level) {
             // Left edge of a "tertiary" run. Set to the right edge of that run.
             while (InlineBox* tertiaryBox = inlineBox->nextLeafChildIgnoringLineBreak()) {
                 if (tertiaryBox->bidiLevel() <= level)
                     break;
                 inlineBox = tertiaryBox;
             }
             caretOffset = inlineBox->caretRightmostOffset();
         }
     }
@@ skipping 90 matching lines @@
     pos.showTreeForThis();
 }
 
 void showTree(const WebCore::Position* pos)
 {
     if (pos)
         pos->showTreeForThis();
 }
 
 #endif