Use correct offset when attribute auto is present

Source/core/dom/Position.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 61 matching lines @@
         if (!renderer)
             continue;
         if (!node->rendererIsEditable())
             continue;
         if ((renderer->isBox() && toRenderBox(renderer)->inlineBoxWrapper()) || (renderer->isText() && toRenderText(renderer)->firstTextBox()))
             return node;
     }
     return 0;
 }
 
+static bool isTextDirectionAuto(Node *node)

[leviw_travelin_and_unemployed, 2014/05/29 16:32:18]

This is asking to be misused. This function doesn't answer the question of
whether or not the node you pass in is dirAuto... It's answering whether or not
the focused element is.

+{
+    bool isAuto = false;
+    if (node->document().focusedElement())

[leviw_travelin_and_unemployed, 2014/05/29 16:32:18]

This just isn't right. getInlineBoxAndOffset shouldn't give different answers
depending on the focused node. I'm fine with you crawling up the ancestor chain
for node, which in your test should yield you the node you're using here, right?

[Habib Virji, 2014/05/30 16:05:10]

On 2014/05/29 16:32:18, leviw wrote:
@leviw: An update, still struggling:

The text area typically renders into:
RenderTextControl {TEXTAREA}, 
 RenderBlock {DIV} 
  RenderText {#text}

So when i traverse upward from anchorNode in getInlineBoxAnfOffset, i end up in
Div and not in TextArea. (I am looking for if node is isBlock or isElement
node.). Attribute dir does not seem to be set for div. 

Regarding selfOrAncestorHasDirAutoAttribute, which gets set from HtmlElement
does not return for the focus node instead when the element is not in focus it
returns correct result. I am debugging further to understand this behavior.

+        toHTMLElement(node->document().focusedElement())->directionalityIfhasDirAutoAttribute(isAuto);
+    return isAuto;
+}
+
 Position::Position(PassRefPtr<Node> anchorNode, LegacyEditingOffset offset)
     : m_anchorNode(anchorNode)
     , m_offset(offset.value())
     , m_anchorType(anchorTypeForLegacyEditingPosition(m_anchorNode.get(), m_offset))
     , m_isLegacyEditingPosition(true)
 {
     ASSERT(!m_anchorNode || !m_anchorNode->isPseudoElement());
 }
 
 Position::Position(PassRefPtr<Node> anchorNode, AnchorType anchorType)
@@ skipping 1161 matching lines @@
         }
     } else {
         InlineBox* nextBox = inlineBox->nextLeafChildIgnoringLineBreak();
         if (!nextBox || nextBox->bidiLevel() < level) {
             // Right edge of a secondary run. Set to the left edge of the entire run.
             while (InlineBox* prevBox = inlineBox->prevLeafChildIgnoringLineBreak()) {
                 if (prevBox->bidiLevel() < level)
                     break;
                 inlineBox = prevBox;
             }
-            caretOffset = inlineBox->caretLeftmostOffset();
+            if (isTextDirectionAuto(m_anchorNode.get()))
+                caretOffset = (inlineBox->bidiLevel() < level) ? inlineBox->caretLeftmostOffset() : inlineBox->caretRightmostOffset();
+            else
+                caretOffset = inlineBox->caretLeftmostOffset();
         } else if (nextBox->bidiLevel() > level) {
             // Left edge of a "tertiary" run. Set to the right edge of that run.
             while (InlineBox* tertiaryBox = inlineBox->nextLeafChildIgnoringLineBreak()) {
                 if (tertiaryBox->bidiLevel() <= level)
                     break;
                 inlineBox = tertiaryBox;
             }
             caretOffset = inlineBox->caretRightmostOffset();
         }
     }
@@ skipping 86 matching lines @@
     pos.showTreeForThis();
 }
 
 void showTree(const WebCore::Position* pos)
 {
     if (pos)
         pos->showTreeForThis();
 }
 
 #endif