Use correct offset when attribute auto is present

Source/core/dom/Position.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 61 matching lines @@
         if (!renderer)
             continue;
         if (!node->rendererIsEditable())
             continue;
         if ((renderer->isBox() && toRenderBox(renderer)->inlineBoxWrapper()) || (renderer->isText() && toRenderText(renderer)->firstTextBox()))
             return node;
     }
     return 0;
 }
 
+static bool hasDirectionAutoAttribute(Node* anchorNode)
+{
+    Node* node = anchorNode;
+    while (node) {
+        if (node->selfOrAncestorHasDirAutoAttribute())
+            return true;
+        if (node->isInShadowTree()) {

[leviw_travelin_and_unemployed, 2014/06/04 17:16:32]

If you're scoping your NodeTraversal to your anchorNode, this shouldn't need to
be in the loop.

[Habib Virji, 2014/06/05 18:57:53]

Ok thanks, i have corrected it. 

+            if (equalIgnoringCase(node->shadowHost()->fastGetAttribute(dirAttr), "auto"))

[leviw_travelin_and_unemployed, 2014/06/04 17:16:32]

is fastGetAttribute(dirAttr) == "auto" ever true when
selfOrAncestorHasDirAutoAttribute() isn't?

[Habib Virji, 2014/06/05 18:57:53]

@leviw: Yes it does work and satisfy the bug test case. It appears position
works with shadowDOM nodes and to access attribute i have to use shadowHost
attributes. While setFlagOrAncestor seem to work on nonShadowElement. 

[leviw_travelin_and_unemployed, 2014/06/05 21:14:05]

If while walking you come across an ancestor with dir=LTR, you'll just keep
walking with this code until you happen to find one with dir=auto.

[Habib Virji, 2014/06/06 13:52:31]

Done. 
Thanks, updated code to check if direction is present. If dir auto then return
true else false. 

+                return true;
+        }
+        node = NodeTraversal::next(*node, anchorNode);

[leviw_travelin_and_unemployed, 2014/06/04 17:16:32]

Why are you using anchorNode as your container? This loop doesn't make a lot of
sense to me.

[Habib Virji, 2014/06/05 18:57:53]

@leviw: i was trying to address, esphern comment about trying to look more than
1 level for shadowHost. 

[leviw_travelin_and_unemployed, 2014/06/05 21:14:05]

I understand what you wanted to address, but this isn't the right way to do
that. Higher shadow hosts won't be next in the NodeTraversal. You're walking
across when he was saying you have to walk up.

[Habib Virji, 2014/06/06 13:52:31]

Done. Corrected now. 

+    }
+    return false;
+}
+
 Position::Position(PassRefPtrWillBeRawPtr<Node> anchorNode, LegacyEditingOffset offset)
     : m_anchorNode(anchorNode)
     , m_offset(offset.value())
     , m_anchorType(anchorTypeForLegacyEditingPosition(m_anchorNode.get(), m_offset))
     , m_isLegacyEditingPosition(true)
 {
     ASSERT(!m_anchorNode || !m_anchorNode->isPseudoElement());
 }
 
 Position::Position(PassRefPtrWillBeRawPtr<Node> anchorNode, AnchorType anchorType)
@@ skipping 1161 matching lines @@
         }
     } else {
         InlineBox* nextBox = inlineBox->nextLeafChildIgnoringLineBreak();
         if (!nextBox || nextBox->bidiLevel() < level) {
             // Right edge of a secondary run. Set to the left edge of the entire run.
             while (InlineBox* prevBox = inlineBox->prevLeafChildIgnoringLineBreak()) {
                 if (prevBox->bidiLevel() < level)
                     break;
                 inlineBox = prevBox;
             }
-            caretOffset = inlineBox->caretLeftmostOffset();
+            if (hasDirectionAutoAttribute(m_anchorNode.get()))
+                caretOffset = (inlineBox->bidiLevel() < level) ? inlineBox->caretLeftmostOffset() : inlineBox->caretRightmostOffset();
+            else
+                caretOffset = inlineBox->caretLeftmostOffset();
         } else if (nextBox->bidiLevel() > level) {
             // Left edge of a "tertiary" run. Set to the right edge of that run.
             while (InlineBox* tertiaryBox = inlineBox->nextLeafChildIgnoringLineBreak()) {
                 if (tertiaryBox->bidiLevel() <= level)
                     break;
                 inlineBox = tertiaryBox;
             }
             caretOffset = inlineBox->caretRightmostOffset();
         }
     }
@@ skipping 90 matching lines @@
     pos.showTreeForThis();
 }
 
 void showTree(const WebCore::Position* pos)
 {
     if (pos)
         pos->showTreeForThis();
 }
 
 #endif