Use correct offset when attribute auto is present

Source/core/dom/Position.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1242 matching lines @@
         }
     } else {
         InlineBox* nextBox = inlineBox->nextLeafChildIgnoringLineBreak();
         if (!nextBox || nextBox->bidiLevel() < level) {
             // Right edge of a secondary run. Set to the left edge of the entire run.
             while (InlineBox* prevBox = inlineBox->prevLeafChildIgnoringLineBreak()) {
                 if (prevBox->bidiLevel() < level)
                     break;
                 inlineBox = prevBox;
             }
-            caretOffset = inlineBox->caretLeftmostOffset();
+            // A special scenario when attribute auto is set. if the direction is changed use right offset

[leviw_travelin_and_unemployed, 2014/05/28 17:42:31]

It's not just "attribute auto," but dirAuto.

Instead of the comment, how about a static method with an informative name? This
function is already way too long.

[Habib Virji, 2014/05/29 07:58:26]

Ok thanks will update accordingly.

[Habib Virji, 2014/05/29 11:31:51]

Done.

+            bool isAuto = false;
+            if (deprecatedNode()->document().focusedElement())

[leviw_travelin_and_unemployed, 2014/05/28 17:42:31]

Why the check for a focused element?

[Habib Virji, 2014/05/29 07:58:26]

I need a way to access directionality function and wanted to make sure element
being checked for attribute has direction auto set.

+                toHTMLElement(deprecatedNode()->document().focusedElement())->directionalityIfhasDirAutoAttribute(isAuto);

[leviw_travelin_and_unemployed, 2014/05/28 17:42:31]

directionalityIfhasDirAutoAttributre returns the directionality, which you're
not using here.

You're also calling deprecatedNode() to get the document. You should use the
document method or poke directly at m_anchorNode since you're inside of position
code.

[Habib Virji, 2014/05/29 07:58:26]

directionalityIfhasDirAutoAttribute takes bool argument and returns true/false
too depending on if the attribute is present. I am not using TextDirection as
bidiLevel checks were in place. 

Okay will try with m_anchorNode was not aware about it. Thanks. 

[Habib Virji, 2014/05/29 11:31:51]

Done.

+            if (isAuto)
+                caretOffset = (inlineBox->bidiLevel() < level) ? inlineBox->caretLeftmostOffset() : inlineBox->caretRightmostOffset();
+            else
+                caretOffset = inlineBox->caretLeftmostOffset();
         } else if (nextBox->bidiLevel() > level) {
             // Left edge of a "tertiary" run. Set to the right edge of that run.
             while (InlineBox* tertiaryBox = inlineBox->nextLeafChildIgnoringLineBreak()) {
                 if (tertiaryBox->bidiLevel() <= level)
                     break;
                 inlineBox = tertiaryBox;
             }
             caretOffset = inlineBox->caretRightmostOffset();
         }
     }
@@ skipping 86 matching lines @@
     pos.showTreeForThis();
 }
 
 void showTree(const WebCore::Position* pos)
 {
     if (pos)
         pos->showTreeForThis();
 }
 
 #endif