LayoutTests/editing/selection/caret-in-textarea-auto.html - Issue 302433015: Use correct offset when attribute auto is present

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/caret-in-textarea-auto.html

Issue 302433015: Use correct offset when attribute auto is present (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated to latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <p>

	5 This tests that typing in a textarea with direction auto and having RTL text. Wh en entering a LTR text caret position is changed.

	6 To test manually, click at the end of RTL text and press enter. Then enter text, caret should move along with the text.

	7 </p>

	8 <textarea id="textarea" dir="auto" style="font-size: 20px; width: 20ex; border: solid thin black; padding: 10px;">א!</textarea>

	9 <script src="../editing.js"></script>

	10 <script>

	11 var textarea = document.getElementById('textarea');

	12 textarea.focus();

	13 window.testRunner.execCommand('MoveToEndOfLine');

	14 document.execCommand('InsertLineBreak');

	15 document.execCommand('InsertText', false, 'hello!');

	16 caretRect = textInputController.firstRectForCharacterRange(1, 0);
	leviw_travelin_and_unemployed 2014/05/28 17:42:31 Can we test this programmatically instead of using Can we test this programmatically instead of using a render tree dump? Why are you getting the caretRect but not using it? Habib Virji 2014/05/29 07:58:26 A valid point will correct it. Was planning to use Show quoted text On 2014/05/28 17:42:31, leviw wrote: > Can we test this programmatically instead of using a render tree dump? Why are > you getting the caretRect but not using it? A valid point will correct it. Was planning to use it but instead thought of using render tree as it was providing caret information. Habib Virji 2014/05/29 11:31:51 Done. Show quoted text On 2014/05/28 17:42:31, leviw wrote: > Can we test this programmatically instead of using a render tree dump? Why are > you getting the caretRect but not using it? Done.
	17 </script>

	18 </body>

	19 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/editing/selection/caret-in-textarea-auto-expected.txt » ('j') | Source/core/dom/Position.cpp » ('J')