Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3234)

Unified Diff: chrome/browser/history/android/sqlite_cursor_unittest.cc

Issue 302433010: Pass an instance of FaviconClient to FaviconService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@latest2
Patch Set: Added include. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/android/sqlite_cursor_unittest.cc
diff --git a/chrome/browser/history/android/sqlite_cursor_unittest.cc b/chrome/browser/history/android/sqlite_cursor_unittest.cc
index f2fff07fe169c467564030963b2508946fb6c005..0896e66086c40783f33118ea81dd93030b7f2cd1 100644
--- a/chrome/browser/history/android/sqlite_cursor_unittest.cc
+++ b/chrome/browser/history/android/sqlite_cursor_unittest.cc
@@ -12,6 +12,8 @@
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/favicon/chrome_favicon_client.h"
+#include "chrome/browser/favicon/chrome_favicon_client_factory.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/history/android/android_history_provider_service.h"
#include "chrome/browser/history/android/android_history_types.h"
@@ -198,7 +200,10 @@ TEST_F(SQLiteCursorTest, Run) {
column_names.push_back(HistoryAndBookmarkRow::GetAndroidName(
HistoryAndBookmarkRow::FAVICON));
- FaviconService* favicon_service = new FaviconService(testing_profile_);
+ FaviconClient* favicon_client =
+ ChromeFaviconClientFactory::GetForProfile(testing_profile_);
+ FaviconService* favicon_service =
+ new FaviconService(testing_profile_, favicon_client);
SQLiteCursor* cursor = new SQLiteCursor(column_names, statement,
service_.get(), favicon_service);
« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698