Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302433009: Fix computation of local-to-border-box transform for RenderSVGRoot (Closed)

Created:
6 years, 6 months ago by fs
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Visibility:
Public.

Description

Fix computation of local-to-border-box transform for RenderSVGRoot Use isZero() instead of isEmpty() to correctly handle cases where only one of the "dimensions" are non-zero. BUG=377362 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174855

Patch Set 1 #

Total comments: 2

Patch Set 2 : Load matrix and check identity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
A LayoutTests/svg/custom/svg-root-padding-left.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/svg-root-padding-left-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/svg-root-padding-top.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/svg-root-padding-top-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
6 years, 6 months ago (2014-05-27 08:51:24 UTC) #1
kouhei (in TOK)
non-owner lgtm
6 years, 6 months ago (2014-05-27 08:52:40 UTC) #2
davve
https://codereview.chromium.org/302433009/diff/1/Source/core/rendering/svg/RenderSVGRoot.cpp File Source/core/rendering/svg/RenderSVGRoot.cpp (right): https://codereview.chromium.org/302433009/diff/1/Source/core/rendering/svg/RenderSVGRoot.cpp#newcode340 Source/core/rendering/svg/RenderSVGRoot.cpp:340: if (borderAndPadding.isZero() && scale == 1 && translate == ...
6 years, 6 months ago (2014-05-27 09:16:51 UTC) #3
fs
https://codereview.chromium.org/302433009/diff/1/Source/core/rendering/svg/RenderSVGRoot.cpp File Source/core/rendering/svg/RenderSVGRoot.cpp (right): https://codereview.chromium.org/302433009/diff/1/Source/core/rendering/svg/RenderSVGRoot.cpp#newcode340 Source/core/rendering/svg/RenderSVGRoot.cpp:340: if (borderAndPadding.isZero() && scale == 1 && translate == ...
6 years, 6 months ago (2014-05-27 10:15:30 UTC) #4
davve
non-owner LGTM
6 years, 6 months ago (2014-05-27 10:39:05 UTC) #5
philipj_slow
lgtm
6 years, 6 months ago (2014-05-27 10:46:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/302433009/20001
6 years, 6 months ago (2014-05-27 10:46:42 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-27 11:27:43 UTC) #8
Message was sent while issue was closed. 
Change committed as 174855

Powered by Google App Engine
This is Rietveld 408576698