Issue 302433005: bindings GYP: split off scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302433005: bindings GYP: split off scripts (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)

Modified:
6 years, 7 months ago

Reviewers:
haraken, Nico

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

bindings GYP: split off scripts This factors out the pre-caching steps (lexer/parser tables and templates), which are for internal use by the compiler and will need to be used by both bindings_core and bindings_modules. Also factors out the scripts/ and templates/ files to .gypi files, so now well-factored. R=haraken TBR=Nico BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174836

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -106 lines)			Patch
M	Source/bindings/bindings.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/core/v8/generated.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/generated.gyp	View	3 chunks	+4 lines, -103 lines	0 comments	Download
M	Source/bindings/modules/v8/generated.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	Source/bindings/scripts/scripts.gyp	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	Source/bindings/scripts/scripts.gypi	View	1 chunk	+44 lines, -0 lines	0 comments	Download
A	Source/bindings/templates/templates.gypi	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 7 months ago (2014-05-27 03:55:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/302433005/1

6 years, 7 months ago (2014-05-27 03:56:08 UTC) #4

Message was sent while issue was closed.

Change committed as 174836

Expand Messages | Collapse Messages