Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 302403003: Include browser_tests.exe in output of official Chrome Windows builds. (Closed)

Created:
6 years, 6 months ago by anandc
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Include browser_tests.exe in output of official Chrome Windows builds. BUG=379986 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274538

Patch Set 1 #

Total comments: 2

Patch Set 2 : Alphabetize list of test names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/tools/build/win/TESTS View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
anandc
Hello Reviewers, PTAL. This change brings to Windows official Chrome builds a test binary that ...
6 years, 6 months ago (2014-06-03 00:52:48 UTC) #1
robertshield
Change LGTM. Please s/browser_test/browser_tests/ in the CL description. https://codereview.chromium.org/302403003/diff/1/chrome/tools/build/win/TESTS File chrome/tools/build/win/TESTS (right): https://codereview.chromium.org/302403003/diff/1/chrome/tools/build/win/TESTS#newcode3 chrome/tools/build/win/TESTS:3: browser_tests.exe ...
6 years, 6 months ago (2014-06-03 00:59:05 UTC) #2
anandc
On 2014/06/03 00:59:05, robertshield wrote: > Change LGTM. > > Please s/browser_test/browser_tests/ in the CL ...
6 years, 6 months ago (2014-06-03 01:24:38 UTC) #3
anandc
https://codereview.chromium.org/302403003/diff/1/chrome/tools/build/win/TESTS File chrome/tools/build/win/TESTS (right): https://codereview.chromium.org/302403003/diff/1/chrome/tools/build/win/TESTS#newcode3 chrome/tools/build/win/TESTS:3: browser_tests.exe On 2014/06/03 00:59:05, robertshield wrote: > optional: while ...
6 years, 6 months ago (2014-06-03 01:24:58 UTC) #4
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-03 01:25:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/302403003/20001
6 years, 6 months ago (2014-06-03 01:25:49 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 05:07:50 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 07:14:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/20549)
6 years, 6 months ago (2014-06-03 07:14:01 UTC) #9
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-03 14:53:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/302403003/20001
6 years, 6 months ago (2014-06-03 14:54:12 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 15:23:45 UTC) #12
Message was sent while issue was closed.
Change committed as 274538

Powered by Google App Engine
This is Rietveld 408576698