Issue 302383002: VM: Use a fake parsed function when parsing metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302383002: VM: Use a fake parsed function when parsing metadata. (Closed)

Created:
6 years, 6 months ago by rmacnak

Modified:
6 years, 6 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

VM: Use a fake parsed function when parsing metadata. BUG=http://dartbug.com/18976 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36903

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -47 lines)			Patch
	M	runtime/vm/parser.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	runtime/vm/parser.cc	View	1	10 chunks	+19 lines, -42 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM. Nice cleanup. https://codereview.chromium.org/302383002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/302383002/diff/1/runtime/vm/parser.cc#newcode8505 runtime/vm/parser.cc:8505: // In metadata, an unresolved identifier ...

6 years, 6 months ago (2014-06-02 21:49:42 UTC) #2

rmacnak

https://codereview.chromium.org/302383002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/302383002/diff/1/runtime/vm/parser.cc#newcode8505 runtime/vm/parser.cc:8505: // In metadata, an unresolved identifier cannot be a ...

6 years, 6 months ago (2014-06-02 22:05:20 UTC) #3

rmacnak

6 years, 6 months ago (2014-06-02 22:06:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36903 (presubmit successful).

Expand Messages | Collapse Messages

Issue 302383002: VM: Use a fake parsed function when parsing metadata. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages