Issue 302363002: Revert "Fix textfield blur, to prevent resetting the text input client when navigating between text…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302363002: Revert "Fix textfield blur, to prevent resetting the text input client when navigating between text… (Closed)

Created:
6 years, 6 months ago by kevers

Modified:
6 years, 6 months ago

Reviewers:
Shu Chen, oshima

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su, stevenjb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Fix textfield blur, to prevent resetting the text input client when navigating between text fields." The fix to use OnTextInputTypeChanged in place of OnFocus and OnBlur to resolve focus loss on text field navigation has introduced a number of regressions. As it turns out, the fix is no longer even necessary to address the original bug that it was intended to address (365741). This patch is a revert of r270818. BUG=375125, 377359, 378914 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274374

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -31 lines)			Patch
	M	ui/views/controls/textfield/textfield.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	ui/views/controls/textfield/textfield_unittest.cc	View		1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/302363002/1

6 years, 6 months ago (2014-06-02 19:34:25 UTC) #4

Message was sent while issue was closed.

Change committed as 274374

Expand Messages | Collapse Messages