Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 302323003: use most innocuous characters possible within skimage output filenames (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

use most innocuous characters possible within skimage output filenames BUG=skia:2634 Committed: https://skia.googlesource.com/skia/+/8ff38ccb40ee4cf5f7f4ea2be424419d1124511f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/skimage_main.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
epoger
Oy vey. PTAL. https://codereview.chromium.org/302323003/diff/1/tools/skimage_main.cpp File tools/skimage_main.cpp (right): https://codereview.chromium.org/302323003/diff/1/tools/skimage_main.cpp#newcode598 tools/skimage_main.cpp:598: SkString subsetDim = SkStringPrintf("%d_%d_%d_%d", rect.fLeft, rect.fTop, ...
6 years, 6 months ago (2014-06-02 21:12:29 UTC) #1
scroggo
On 2014/06/02 21:12:29, epoger wrote: > Oy vey. PTAL. > > https://codereview.chromium.org/302323003/diff/1/tools/skimage_main.cpp > File tools/skimage_main.cpp ...
6 years, 6 months ago (2014-06-02 21:20:17 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 6 months ago (2014-06-02 21:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/302323003/1
6 years, 6 months ago (2014-06-02 21:21:25 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:26:21 UTC) #5
Message was sent while issue was closed.
Change committed as 8ff38ccb40ee4cf5f7f4ea2be424419d1124511f

Powered by Google App Engine
This is Rietveld 408576698