Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 302313006: GoogleURLTrackerInfoBarDelegate: Initialize uninitialized member in constructor (Closed)

Created:
6 years, 6 months ago by Finnur
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman, blundell
CC:
chromium-reviews
Visibility:
Public.

Description

GoogleURLTrackerInfoBarDelegate: Initialize uninitialized member in constructor. BUG=None CID=115981 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/google/google_url_tracker_infobar_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Finnur
6 years, 6 months ago (2014-06-02 21:19:45 UTC) #1
blundell
lgtm Thanks!
6 years, 6 months ago (2014-06-03 08:28:34 UTC) #2
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 6 months ago (2014-06-03 17:36:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/302313006/1
6 years, 6 months ago (2014-06-03 17:36:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 18:24:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 18:28:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71353)
6 years, 6 months ago (2014-06-03 18:28:40 UTC) #7
Finnur
isherman: Mind doing an owners check here?
6 years, 6 months ago (2014-06-03 18:29:09 UTC) #8
Ilya Sherman
LGTM, thanks.
6 years, 6 months ago (2014-06-03 20:31:14 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 6 months ago (2014-06-03 20:31:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/302313006/1
6 years, 6 months ago (2014-06-03 20:32:12 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:48:25 UTC) #12
Message was sent while issue was closed.
Change committed as 274639

Powered by Google App Engine
This is Rietveld 408576698