Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(157)

Issue 3023052: Merging r55430 to the M6 branch:... (Closed)

Created:
8 years, 5 months ago by Jay Civelli
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org
Visibility:
Public.

Description

Merging r55430 to the M6 branch: Fix crasher with download bar. When dragging out a file, the download bar is shown and disappear automatically once the download is complete. If the download item menu was opened at that point, we would crash. This was because showing the menu runs an inner message loop that would process the hide for the download bar, leading to the download item that was on the call-stack to be deleted, causing a crasher once the stack-unwinded and the deleted object was accessed. BUG=51187 TEST=In GMail, open an email with a large attachment (like 2 MB). Drag the file from GMail to your desktop. Click on the arrow on the item on the download bar to bring up the download menu. Keep the menu open until the download is completed and the bar gets hidden. It should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/views/download_item_view.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 3 chunks +11 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698