MacViews: Extend TextInputClient protocol with support for editing commands.

MacViews: Extend TextInputClient protocol with support for editing commands.

Extend TextInputClient to support validating and executing editing commands,
such as IDS_DELETE_BACKWARD, IDS_MOVE_RIGHT, IDS_APP_PASTE.
This will be used for implementing Textfield editing for the Mac port of Views.

BUG=374077
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275294

[Yuki, 2014-06-03 07:52:11]

lgtm

https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_client.h
File ui/base/ime/text_input_client.h (right):

https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_clien...
ui/base/ime/text_input_client.h:170: virtual bool IsEditingCommandEnabled(int
command_id) = 0;
Do you know TextEditCommandAuraLinux in
ui/events/linux/text_edit_command_auralinux.h ?

You may want to follow this way, or want something similar to this, or may not. 
FYI.

[Andre, 2014-06-03 16:03:15]

On 2014/06/03 07:52:11, Yuki wrote:
> lgtm
> 
>
https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_client.h
> File ui/base/ime/text_input_client.h (right):
> 
>
https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_clien...
> ui/base/ime/text_input_client.h:170: virtual bool IsEditingCommandEnabled(int
> command_id) = 0;
> Do you know TextEditCommandAuraLinux in
> ui/events/linux/text_edit_command_auralinux.h ?
> 
> You may want to follow this way, or want something similar to this, or may
not. 
> FYI.

Thanks Yuki, that might be useful later on.

[Andre, 2014-06-03 16:04:23]

Ben, can you review as owner of views and content?

[Ben Goodger (Google), 2014-06-05 15:38:20]

lgtm but see note below:

https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_client.h
File ui/base/ime/text_input_client.h (right):

https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_clien...
ui/base/ime/text_input_client.h:170: virtual bool IsEditingCommandEnabled(int
command_id) = 0;
You should provide some documentation here for what this does.

[Andre, 2014-06-05 17:39:12]

The CQ bit was checked by andresantoso@chromium.org

[Andre, 2014-06-05 17:39:22]

https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_client.h
File ui/base/ime/text_input_client.h (right):

https://codereview.chromium.org/302293003/diff/1/ui/base/ime/text_input_clien...
ui/base/ime/text_input_client.h:170: virtual bool IsEditingCommandEnabled(int
command_id) = 0;
On 2014/06/05 15:38:20, Ben Goodger (Google) wrote:
> You should provide some documentation here for what this does.

Done.

[commit-bot: I haz the power, 2014-06-05 17:40:22]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/andresantoso@chromium.org/302293003/20001

[commit-bot: I haz the power, 2014-06-05 21:32:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-06 01:36:51]

Change committed as 275294