[Android] Fix AutofillPopup positioning in RTL mode.

[Android] Fix AutofillPopup positioning in RTL mode.

BUG=372926
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274748

[aurimas (slooooooooow), 2014-06-03 01:36:19]

Hey Ted,

PTAL.

Aurimas

[aurimas (slooooooooow), 2014-06-03 20:10:44]

On 2014/06/03 01:36:19, aurimas wrote:
> Hey Ted,
> 
> PTAL.
> 
> Aurimas

ping?

[Ted C, 2014-06-03 20:30:24]

lgtm w/ a couple questions

https://chromiumcodereview.appspot.com/302283008/diff/1/content/public/androi...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://chromiumcodereview.appspot.com/302283008/diff/1/content/public/androi...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:450:
- Math.round((width + x) * scale);
the scaledWidth is compensated above to ensure it doesn't draw over the side. 
Does that need to change for RTL?

in theory this should be the same as setting left margin if the scale is == 1f
right?  It's just that this needs to account for scaled width at other times to
ensure it aligns to the right edge?

[aurimas (slooooooooow), 2014-06-03 21:25:46]

https://chromiumcodereview.appspot.com/302283008/diff/1/content/public/androi...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://chromiumcodereview.appspot.com/302283008/diff/1/content/public/androi...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:450:
- Math.round((width + x) * scale);
On 2014/06/03 20:30:24, Ted C wrote:
> the scaledWidth is compensated above to ensure it doesn't draw over the side. 
> Does that need to change for RTL?
> 
> in theory this should be the same as setting left margin if the scale is == 1f
> right?  It's just that this needs to account for scaled width at other times
to
> ensure it aligns to the right edge?

Fixed this. See the new patch.

[aurimas (slooooooooow), 2014-06-03 21:33:32]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-06-03 21:34:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/302283008/20001

[commit-bot: I haz the power, 2014-06-04 00:36:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[aurimas (slooooooooow), 2014-06-04 01:32:15]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-06-04 01:33:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/302283008/20001

[commit-bot: I haz the power, 2014-06-04 09:28:17]

Change committed as 274748