Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 302283007: sync: Populate entity counts in about:sync tab (Closed)

Created:
6 years, 6 months ago by rlarocque
Modified:
6 years, 6 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

sync: Populate entity counts in about:sync tab Populates the count of entities per type in about:sync. Includes C++ code to count and emit the set of deleted and non-deleted counts, though for space reasons only the non-deleted count is displayed on the about:sync page. This calculation is somewhat expensive. It could be made cheaper by having an index in the Directory to keep track of which entities belong to which type, but that doesn't exist at the moment. For now, we just avoid calculating these counts unless the about:sync page is open. BUG=349301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M sync/engine/directory_commit_contribution.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sync/engine/directory_update_handler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M sync/internal_api/public/sessions/status_counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/public/sessions/status_counters.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/sessions/directory_type_debug_info_emitter.cc View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
rlarocque
Here's the follow-up to r274348, aka. https://codereview.chromium.org/290023003/. I had intended to spend a bit more ...
6 years, 6 months ago (2014-06-03 00:07:09 UTC) #1
maniscalco
LGTM. I agree about keeping it simple and not trying to make it more efficient.
6 years, 6 months ago (2014-06-03 00:42:40 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 6 months ago (2014-06-03 00:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/302283007/1
6 years, 6 months ago (2014-06-03 00:48:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 05:04:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 06:58:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/20546)
6 years, 6 months ago (2014-06-03 06:58:41 UTC) #7
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 6 months ago (2014-06-03 17:08:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/302283007/1
6 years, 6 months ago (2014-06-03 17:09:23 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 17:34:34 UTC) #10
Message was sent while issue was closed.
Change committed as 274563

Powered by Google App Engine
This is Rietveld 408576698