Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: chrome/test/chromedriver/capabilities_unittest.cc

Issue 302273003: [ChromeDriver] Fix embed mobilde devices script for new Blink roll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/chromedriver/embed_mobile_devices_in_cpp.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/capabilities.h" 5 #include "chrome/test/chromedriver/capabilities.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/test/chromedriver/chrome/log.h" 8 #include "chrome/test/chromedriver/chrome/log.h"
9 #include "chrome/test/chromedriver/chrome/status.h" 9 #include "chrome/test/chromedriver/chrome/status.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 base::DictionaryValue caps; 385 base::DictionaryValue caps;
386 caps.Set("chromeOptions.mobileEmulation", mobile_emulation.DeepCopy()); 386 caps.Set("chromeOptions.mobileEmulation", mobile_emulation.DeepCopy());
387 Status status = capabilities.Parse(caps); 387 Status status = capabilities.Parse(caps);
388 ASSERT_TRUE(status.IsOk()); 388 ASSERT_TRUE(status.IsOk());
389 389
390 ASSERT_EQ(360, capabilities.device_metrics->width); 390 ASSERT_EQ(360, capabilities.device_metrics->width);
391 ASSERT_EQ(640, capabilities.device_metrics->height); 391 ASSERT_EQ(640, capabilities.device_metrics->height);
392 ASSERT_EQ(3.0, capabilities.device_metrics->device_scale_factor); 392 ASSERT_EQ(3.0, capabilities.device_metrics->device_scale_factor);
393 } 393 }
394 394
395 TEST(ParseCapabilities, DISABLED_MobileEmulationDeviceName) { 395 TEST(ParseCapabilities, MobileEmulationDeviceName) {
396 Capabilities capabilities; 396 Capabilities capabilities;
397 base::DictionaryValue mobile_emulation; 397 base::DictionaryValue mobile_emulation;
398 mobile_emulation.SetString("deviceName", "Google Nexus 5"); 398 mobile_emulation.SetString("deviceName", "Google Nexus 5");
399 base::DictionaryValue caps; 399 base::DictionaryValue caps;
400 caps.Set("chromeOptions.mobileEmulation", mobile_emulation.DeepCopy()); 400 caps.Set("chromeOptions.mobileEmulation", mobile_emulation.DeepCopy());
401 Status status = capabilities.Parse(caps); 401 Status status = capabilities.Parse(caps);
402 ASSERT_TRUE(status.IsOk()); 402 ASSERT_TRUE(status.IsOk());
403 403
404 ASSERT_EQ(1u, capabilities.switches.GetSize()); 404 ASSERT_EQ(1u, capabilities.switches.GetSize());
405 ASSERT_TRUE(capabilities.switches.HasSwitch("user-agent")); 405 ASSERT_TRUE(capabilities.switches.HasSwitch("user-agent"));
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 base::DictionaryValue mobile_emulation; 449 base::DictionaryValue mobile_emulation;
450 mobile_emulation.SetString("deviceName", "Google Nexus 5"); 450 mobile_emulation.SetString("deviceName", "Google Nexus 5");
451 mobile_emulation.SetInteger("deviceMetrics.width", 360); 451 mobile_emulation.SetInteger("deviceMetrics.width", 360);
452 mobile_emulation.SetInteger("deviceMetrics.height", 640); 452 mobile_emulation.SetInteger("deviceMetrics.height", 640);
453 mobile_emulation.SetDouble("deviceMetrics.pixelRatio", 3.0); 453 mobile_emulation.SetDouble("deviceMetrics.pixelRatio", 3.0);
454 base::DictionaryValue caps; 454 base::DictionaryValue caps;
455 caps.Set("chromeOptions.mobileEmulation", mobile_emulation.DeepCopy()); 455 caps.Set("chromeOptions.mobileEmulation", mobile_emulation.DeepCopy());
456 Status status = capabilities.Parse(caps); 456 Status status = capabilities.Parse(caps);
457 ASSERT_FALSE(status.IsOk()); 457 ASSERT_FALSE(status.IsOk());
458 } 458 }
OLDNEW
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/test/chromedriver/embed_mobile_devices_in_cpp.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698