Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: Source/modules/webmidi/MIDIConnectionEvent.h

Issue 302263004: Oilpan: Move [WillBeGarbageCollected] from Node to EventTarget. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/MIDIConnectionEvent.h
diff --git a/Source/modules/webmidi/MIDIConnectionEvent.h b/Source/modules/webmidi/MIDIConnectionEvent.h
index 4e9015a7fcf3ea26c2320b46d6067aea9a8ae0c5..850aa2d4dc424d095b081015c4901c8367eeb2e7 100644
--- a/Source/modules/webmidi/MIDIConnectionEvent.h
+++ b/Source/modules/webmidi/MIDIConnectionEvent.h
@@ -52,7 +52,7 @@ public:
return adoptRefWillBeNoop(new MIDIConnectionEvent());
}
- static PassRefPtrWillBeRawPtr<MIDIConnectionEvent> create(const AtomicString& type, PassRefPtr<MIDIPort> port)
+ static PassRefPtrWillBeRawPtr<MIDIConnectionEvent> create(const AtomicString& type, PassRefPtrWillBeRawPtr<MIDIPort> port)
{
return adoptRefWillBeNoop(new MIDIConnectionEvent(type, port));
}
@@ -62,11 +62,15 @@ public:
return adoptRefWillBeNoop(new MIDIConnectionEvent(type, initializer));
}
- RefPtr<MIDIPort> port() { return m_port; }
+ RefPtrWillBeRawPtr<MIDIPort> port() { return m_port; }
haraken 2014/06/02 07:25:06 Not related to your CL, this should be PassRefPtrW
zerny-chromium 2014/06/02 07:47:33 Done.
virtual const AtomicString& interfaceName() const OVERRIDE { return EventNames::MIDIConnectionEvent; }
- virtual void trace(Visitor* visitor) OVERRIDE { Event::trace(visitor); }
+ virtual void trace(Visitor* visitor) OVERRIDE
+ {
+ visitor->trace(m_port);
+ Event::trace(visitor);
+ }
private:
MIDIConnectionEvent()
@@ -74,7 +78,7 @@ private:
ScriptWrappable::init(this);
}
- MIDIConnectionEvent(const AtomicString& type, PassRefPtr<MIDIPort> port)
+ MIDIConnectionEvent(const AtomicString& type, PassRefPtrWillBeRawPtr<MIDIPort> port)
: Event(type, false, false)
, m_port(port)
{
@@ -88,7 +92,7 @@ private:
ScriptWrappable::init(this);
}
- RefPtr<MIDIPort> m_port;
+ RefPtrWillBeMember<MIDIPort> m_port;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698