Oilpan: Move [WillBeGarbageCollected] from Node to EventTarget.

Source/modules/webmidi/MIDIConnectionEvent.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
 #include "modules/webmidi/MIDIPort.h"
 
 namespace WebCore {
 
 struct MIDIConnectionEventInit : public EventInit {
     MIDIConnectionEventInit()
         : port(nullptr)
     {
     };
 
     RefPtr<MIDIPort> port;

[sof, 2014/06/02 12:41:03]

Should this be RefPtrWillBeMember? (Dictionary.h needs updating also, if so.)

[zerny-chromium, 2014/06/02 13:06:49]

I'd rather postpone that to a CL that completes the transition for MIDIPort.
This CL should minimally just support EventTarget and its IDL dependencies. If
you disagree I'm OK with pulling through the change here. (But in general,
moving RefPtrs for EventTarget-derived types is a very large task to complete).

[sof, 2014/06/02 13:11:19]

I'm fine with scoping this CL to that only, and deal with the rest here later.

 };
 
 class MIDIConnectionEvent FINAL : public Event {

[sof, 2014/06/02 12:41:03]

I think this event merits a .cpp file of its own by now.

[zerny-chromium, 2014/06/02 13:06:49]

Ok. I'll add one.

 public:
     static PassRefPtrWillBeRawPtr<MIDIConnectionEvent> create()
     {
         return adoptRefWillBeNoop(new MIDIConnectionEvent());
     }
 
-    static PassRefPtrWillBeRawPtr<MIDIConnectionEvent> create(const AtomicString& type, PassRefPtr<MIDIPort> port)
+    static PassRefPtrWillBeRawPtr<MIDIConnectionEvent> create(const AtomicString& type, PassRefPtrWillBeRawPtr<MIDIPort> port)
     {
         return adoptRefWillBeNoop(new MIDIConnectionEvent(type, port));
     }
 
     static PassRefPtrWillBeRawPtr<MIDIConnectionEvent> create(const AtomicString& type, const MIDIConnectionEventInit& initializer)
     {
         return adoptRefWillBeNoop(new MIDIConnectionEvent(type, initializer));
     }
 
-    RefPtr<MIDIPort> port() { return m_port; }
+    PassRefPtrWillBeRawPtr<MIDIPort> port() { return m_port; }
 
     virtual const AtomicString& interfaceName() const OVERRIDE { return EventNames::MIDIConnectionEvent; }
 
-    virtual void trace(Visitor* visitor) OVERRIDE { Event::trace(visitor); }
+    virtual void trace(Visitor* visitor) OVERRIDE

[sof, 2014/06/02 12:41:03]

Move the definition the .cpp file?

[zerny-chromium, 2014/06/02 13:06:49]

Done.

+    {
+        visitor->trace(m_port);
+        Event::trace(visitor);
+    }
 
 private:
     MIDIConnectionEvent()
     {
         ScriptWrappable::init(this);
     }
 
-    MIDIConnectionEvent(const AtomicString& type, PassRefPtr<MIDIPort> port)
+    MIDIConnectionEvent(const AtomicString& type, PassRefPtrWillBeRawPtr<MIDIPort> port)
         : Event(type, false, false)
         , m_port(port)
     {
         ScriptWrappable::init(this);
     }
 
     MIDIConnectionEvent(const AtomicString& type, const MIDIConnectionEventInit& initializer)
         : Event(type, initializer)
         , m_port(initializer.port)
     {
         ScriptWrappable::init(this);
     }
 
-    RefPtr<MIDIPort> m_port;
+    RefPtrWillBeMember<MIDIPort> m_port;
 };
 
 } // namespace WebCore
 
 #endif // MIDIConnectionEvent_h