Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 302233002: Revert of Empty inline elements always get a line box. (Closed)

Created:
6 years, 6 months ago by rhogan
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, leviw+bidiwatch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Revert of Empty inline elements always get a line box. (https://codereview.chromium.org/300853007/) Reason for revert: This changed the subpixel positioning of glyphs on lines with first-letter renderers on Mac builds. See https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_6/28423/layout-test-results/results.html as an example. I think the new results are benign - but would like to confirm with leviw and reland as NeedsRebaseline if we're both happy with them. Original issue's description: > Empty inline elements always get a line box. > > CSS 2.1 (http://www.w3.org/TR/CSS2/visudet.html#leading) says: "Empty inline > elements generate empty inline boxes, but these boxes still have margins, padding, > borders and a line height, and thus influence [line-height calculation] just > like elements with content." > > We weren't creating lineboxes for empty inline elements when they occurred > between a single trailing space and a single leading space - this is because > our linebox creation was based on the too-narrow premise that we were already > ignoring spaces. However, if an empty inline element comes after a trailing > space but before one or more leading spaces then it will be ignored as part > of the collapsed space between the trailing space and the next non-collapsible > space - so we should force the creation of a linebox in such cases. > > This allows us to pass Hixie's empty inline test: > http://www.hixie.ch/tests/evil/mixed/emptyinline.html > > BUG=328939 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175205 TBR=leviw@chromium.org NOTREECHECKS=true NOTRY=true BUG=328939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -88 lines) Patch
D LayoutTests/fast/inline/empty-inline-before-collapsed-space.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/inline/empty-inline-before-collapsed-space-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/rendering/line/BreakingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 3 chunks +10 lines, -12 lines 0 comments Download
M Source/core/rendering/line/TrailingObjects.h View 3 chunks +6 lines, -19 lines 0 comments Download
M Source/core/rendering/line/TrailingObjects.cpp View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rhogan
Created Revert of Empty inline elements always get a line box.
6 years, 6 months ago (2014-05-31 22:01:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/302233002/1
6 years, 6 months ago (2014-05-31 22:01:40 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 22:02:05 UTC) #3
Message was sent while issue was closed.
Change committed as 175207

Powered by Google App Engine
This is Rietveld 408576698