Set visible viewport value in screen emulation.

Set visible viewport value in screen emulation.

Saved the current value and restore it when emulation ends. During emulation
the visible viewport is set to the size of the emulated screen.

BUG=370035
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274359

[bokan, 2014-05-30 18:44:57]

Dmitry, does this look ok?

[dgozman, 2014-05-30 19:17:52]

I'm not sure what's visible viewport size means. Does this change imply that
virtual viewport will not work with emulation? We may be forced to push
emulation knowledge to the browser, since virtual viewport size is calculated
there.

https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:327: Apply(params.overdraw_bottom_height,
params.resizer_rect,
You should update |original_visible_viewport_size_| here.

[bokan, 2014-05-30 19:43:36]

On 2014/05/30 19:17:52, dgozman wrote:
> I'm not sure what's visible viewport size means. Does this change imply that
> virtual viewport will not work with emulation? We may be forced to push
> emulation knowledge to the browser, since virtual viewport size is calculated
> there.
> 
>
https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
> File content/renderer/render_widget.cc (right):
> 
>
https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
> content/renderer/render_widget.cc:327: Apply(params.overdraw_bottom_height,
> params.resizer_rect,
> You should update |original_visible_viewport_size_| here.

Visible viewport corresponds to the pinch viewport in Blink. It will always be
the same size as the render widget except when the on screen keyboard comes up,
then it's shrunk so that the "visible viewport" is the unobscured part of the
screen, the actual "visible" part of the content. Which virtual viewport do you
refer to? What we've been calling "virtual viewport" is the "pinch viewport" (or
"inner viewport" in the compositor), the browser has no knowledge of that.

[bokan, 2014-05-30 19:43:45]

https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:327: Apply(params.overdraw_bottom_height,
params.resizer_rect,
On 2014/05/30 19:17:52, dgozman wrote:
> You should update |original_visible_viewport_size_| here.

Good catch, thanks.

[dgozman, 2014-05-31 04:19:31]

On 2014/05/30 19:43:36, bokan wrote:
> On 2014/05/30 19:17:52, dgozman wrote:
> > I'm not sure what's visible viewport size means. Does this change imply that
> > virtual viewport will not work with emulation? We may be forced to push
> > emulation knowledge to the browser, since virtual viewport size is
calculated
> > there.
> > 
> >
>
https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
> > File content/renderer/render_widget.cc (right):
> > 
> >
>
https://codereview.chromium.org/302193002/diff/1/content/renderer/render_widg...
> > content/renderer/render_widget.cc:327: Apply(params.overdraw_bottom_height,
> > params.resizer_rect,
> > You should update |original_visible_viewport_size_| here.
> 
> Visible viewport corresponds to the pinch viewport in Blink. It will always be
> the same size as the render widget except when the on screen keyboard comes
up,
> then it's shrunk so that the "visible viewport" is the unobscured part of the
> screen, the actual "visible" part of the content. Which virtual viewport do
you
> refer to? What we've been calling "virtual viewport" is the "pinch viewport"
(or
> "inner viewport" in the compositor), the browser has no knowledge of that.

Now I see. Thanks for clarification. lgtm. I'm not an owner though.

[bokan, 2014-06-02 13:52:04]

+avi@ for OWNER

[Avi (use Gerrit), 2014-06-02 14:44:21]

lgtm

stampity stamp

[bokan, 2014-06-02 15:20:54]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2014-06-02 15:21:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bokan@chromium.org/302193002/20001

[commit-bot: I haz the power, 2014-06-02 20:12:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-02 22:39:31]

Change committed as 274359