Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4531)

Unified Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 302173009: Temporarily disabling apprtc teardown to debug apprtc problems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
index 59dde5015413feda05245f08e33d7cc4af30c75d..20ae8c750c57ad083e9cba38a1a5e5f71d294645 100644
--- a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
@@ -61,11 +61,17 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
virtual void TearDown() OVERRIDE {
// Kill any processes we may have brought up.
+ // TODO(phoglund): Temporarily disabling on win to debug
+ // test hang-on-shutdown.
+ LOG(INFO) << "Entering TearDown";
+#if !defined(OS_WIN)
if (dev_appserver_ != base::kNullProcessHandle)
base::KillProcess(dev_appserver_, 0, false);
+#endif
// TODO(phoglund): Find some way to shut down Firefox cleanly on Windows.
if (firefox_ != base::kNullProcessHandle)
base::KillProcess(firefox_, 0, false);
+ LOG(INFO) << "Exiting TearDown";
}
protected:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698