[Android] Java Bridge with Gin: implement Java methods invocation

content/browser/renderer_host/java/gin_java_method_invocation_helper.h

Index: content/browser/renderer_host/java/gin_java_method_invocation_helper.h
diff --git a/content/browser/renderer_host/java/gin_java_method_invocation_helper.h b/content/browser/renderer_host/java/gin_java_method_invocation_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..5b5d86bbc301bef8a5e4432d60c6e4f14c24cbda
--- /dev/null
+++ b/content/browser/renderer_host/java/gin_java_method_invocation_helper.h
@@ -0,0 +1,139 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_RENDERER_HOST_JAVA_GIN_JAVA_METHOD_INVOCATION_HELPER_H_
+#define CONTENT_BROWSER_RENDERER_HOST_JAVA_GIN_JAVA_METHOD_INVOCATION_HELPER_H_
+
+#include "base/android/jni_weak_ref.h"
+#include "base/android/scoped_java_ref.h"
+#include "base/memory/ref_counted.h"
+#include "base/values.h"
+#include "content/browser/renderer_host/java/gin_java_bound_object.h"
+#include "content/browser/renderer_host/java/java_type.h"
+#include "content/common/content_export.h"
+
+namespace content {
+
+class JavaMethod;
+
+// Instances of this class are created and initialized on the UI thread, do
+// their work on the background thread, and then again examined on the UI
+// thread. They don't work on both threads simultaneously, though.
+class CONTENT_EXPORT GinJavaMethodInvocationHelper
+    : public base::RefCountedThreadSafe<GinJavaMethodInvocationHelper> {
+ public:
+  // DispatcherDelegate is used on the UI thread
+  class DispatcherDelegate {
+   public:
+    virtual ~DispatcherDelegate() {}
+    virtual JavaObjectWeakGlobalRef GetObjectWeakRef(
+        GinJavaBoundObject::ObjectID object_id) = 0;

[bulach, 2014/06/09 11:44:33]

nit: private: DISALLOW_COPY_AND_ASSIGN?

[mnaganov (inactive), 2014/06/11 13:50:44]

A good idea! Done.

+  };
+
+  // ObjectDelegate is used in the background thread
+  class ObjectDelegate {
+   public:
+    virtual ~ObjectDelegate() {}
+    virtual base::android::ScopedJavaLocalRef<jobject> GetLocalRef(
+        JNIEnv* env) = 0;
+    virtual const JavaMethod* FindMethod(const std::string& method_name,
+                                         size_t num_parameters) = 0;
+    virtual bool IsObjectGetClassMethod(const JavaMethod* method) = 0;
+    virtual const base::android::JavaRef<jclass>& GetSafeAnnotationClass() = 0;

[bulach, 2014/06/09 11:44:33]

nit: I think we normally return by value rather than by const ref.

[mnaganov (inactive), 2014/06/11 13:50:44]

It's not possible to return a JavaRef by value because it's non-copyable, you
can only return ScopedJavaLocal / GlobalRef this way.

+  };

[bulach, 2014/06/09 11:44:33]

nit: private DISALLOW_COPY_AND_ASSIGN?

[mnaganov (inactive), 2014/06/11 13:50:44]

Done.

+
+  GinJavaMethodInvocationHelper(scoped_ptr<ObjectDelegate> object,
+                                const std::string& method_name,
+                                const base::ListValue& arguments);
+  void Init(DispatcherDelegate* dispatcher);
+
+  // Called on the background thread
+  void Invoke();
+
+  // Called on the UI thread
+  bool HoldsPrimitiveResult();
+  const base::ListValue& GetPrimitiveResult();
+  const base::android::JavaRef<jobject>& GetObjectResult();
+  const base::android::JavaRef<jclass>& GetSafeAnnotationClass();
+  const std::string& GetErrorMessage();
+
+ private:
+  friend class base::RefCountedThreadSafe<GinJavaMethodInvocationHelper>;
+  ~GinJavaMethodInvocationHelper();
+
+  // Called on the UI thread
+  void BuildObjectRefsFromListValue(DispatcherDelegate* dispatcher,
+                                    const base::Value* list_value);
+  void BuildObjectRefsFromDictionaryValue(DispatcherDelegate* dispatcher,
+                                          const base::Value* dict_value);
+  bool AppendObjectRef(DispatcherDelegate* dispatcher,
+                       const base::Value* raw_value);
+
+  // Called on the background thread.
+  jvalue CoerceJavaScriptValueToJavaValue(const base::Value* value,
+                                          const JavaType& target_type,
+                                          bool coerce_to_string);
+  jvalue CoerceGinJavaBridgeValueToJavaValue(const base::Value* value,
+                                             const JavaType& target_type,
+                                             bool coerce_to_string);
+  jvalue CoerceJavaScriptIntegerToJavaValue(const base::Value* value,
+                                            const JavaType& target_type,
+                                            bool coerce_to_string);
+  jvalue CoerceJavaScriptDoubleToJavaValue(double double_value,
+                                           const JavaType& target_type,
+                                           bool coerce_to_string);
+  jvalue CoerceJavaScriptBooleanToJavaValue(const base::Value* value,
+                                            const JavaType& target_type,
+                                            bool coerce_to_string);
+  jvalue CoerceJavaScriptStringToJavaValue(const base::Value* value,
+                                           const JavaType& target_type);
+  jvalue CoerceJavaScriptObjectToJavaValue(const base::Value* value,
+                                           const JavaType& target_type,
+                                           bool coerce_to_string);
+  jobject CoerceJavaScriptListToArray(const base::Value* value,
+                                      const JavaType& target_type);
+  jobject CoerceJavaScriptDictionaryToArray(
+      const base::Value* value,
+      const JavaType& target_type);
+  jvalue CoerceJavaScriptNullOrUndefinedToJavaValue(const base::Value* value,
+                                                    const JavaType& target_type,
+                                                    bool coerce_to_string);
+  jobject CreateJavaArray(const JavaType& type, jsize length);

[bulach, 2014/06/09 11:44:34]

question: could all these Coerce* methods go into their own
gin_java_type_coercion.h|.cc as a collection of static methods?
I understand there's already a bunch of tests in the java side, but I suppose we
could make this file simpler by splitting it, and then the new tests would only
exercise the behavior added here... wdyt?

[mnaganov (inactive), 2014/06/11 13:50:44]

This makes sense, extracted.

We don't add any new behaviour in our Coerce* methods, I have only converted
them from using NPAPI types to using base::Value and GinJavaBridgeValue.

I have already added tests for GinJavaMethodInvocationHelper itself.

+  void InvokeMethod(jobject object,
+                    const JavaType& return_type,
+                    jmethodID id,
+                    jvalue* parameters);
+  void ReleaseJavaValueIfRequired(JNIEnv* env,
+                                  jvalue* value,
+                                  const JavaType& type);
+  void SetArrayElement(jobject array,
+                       const JavaType& type,
+                       jsize index,
+                       const jvalue& value);
+
+  void SetInvocationFailure(const char* error_message);
+  void SetPrimitiveResult(const base::ListValue& result_wrapper);
+  void SetObjectResult(
+      const base::android::JavaRef<jobject>& object,
+      const base::android::JavaRef<jclass>& safe_annotation_clazz);
+
+  typedef std::map<GinJavaBoundObject::ObjectID,
+                   JavaObjectWeakGlobalRef> ObjectRefs;
+
+  scoped_ptr<ObjectDelegate> object_;
+  const std::string method_name_;
+  scoped_ptr<base::ListValue> arguments_;
+  ObjectRefs object_refs_;
+  bool holds_primitive_result_;
+  scoped_ptr<base::ListValue> primitive_result_;
+  std::string error_message_;
+  base::android::ScopedJavaGlobalRef<jobject> object_result_;
+  base::android::ScopedJavaGlobalRef<jclass> safe_annotation_clazz_;
+
+  DISALLOW_COPY_AND_ASSIGN(GinJavaMethodInvocationHelper);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_RENDERER_HOST_JAVA_GIN_JAVA_METHOD_INVOCATION_HELPER_H_