Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 302173003: Mojo: Make mojo_shell able to load apps from file: URLs. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Make mojo_shell able to load apps from file: URLs. E.g., something like out/Debug/mojo_shell file://$PWD/out/Debug/lib/libmojo_sample_app.so should work. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M mojo/shell/loader.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
6 years, 6 months ago (2014-05-30 23:36:14 UTC) #1
viettrungluu
-> sky instead
6 years, 6 months ago (2014-06-02 20:16:12 UTC) #2
sky
LGTM
6 years, 6 months ago (2014-06-02 20:25:07 UTC) #3
viettrungluu
6 years, 6 months ago (2014-06-02 20:37:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r274317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698