Issue 302163005: Change InMemoryContentStore to use MRUCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302163005: Change InMemoryContentStore to use MRUCache. (Closed)

Created:
6 years, 6 months ago by nyquist

Modified:
6 years, 6 months ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change InMemoryContentStore to use MRUCache. This CL changes the backing store for the InMemoryContentStore to now be of type base::MRUCache. This ensures that the growth of the store is not unbounded. Tests are also added to ensure the new functionality works as expected. BUG=379642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274754

Patch Set 1 #

Patch Set 2 : Start using MRUCache #

Patch Set 3 : Updated tests for expiry and fixed lint errors. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+272 lines, -20 lines)			Patch
M	components/components_tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/dom_distiller/core/distilled_content_store.h	View	1 2	3 chunks	+13 lines, -9 lines	0 comments	Download
M	components/dom_distiller/core/distilled_content_store.cc	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download
A	components/dom_distiller/core/distilled_content_store_unittest.cc	View	1 2	1 chunk	+243 lines, -0 lines	0 comments	Download
M	components/dom_distiller/core/dom_distiller_service.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	components/dom_distiller/core/task_tracker_unittest.cc	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/302163005/40001

6 years, 6 months ago (2014-06-03 22:31:21 UTC) #4

Message was sent while issue was closed.

Change committed as 274754

Expand Messages | Collapse Messages