Update Status Area Paint Scheduling

Update Status Area Paint Scheduling

With each TrayBackgroundView now backed by its own layer, calling SchedulePaint on StatusAreaWidgetDelegate no longer notifies them of the need to paint.

When the shelf changes its dimming state it triggers painting. Add support for StatusAreaWidget to notify each of the layer backed trays that painting is needed

TEST=Launch a non-maximized browser. The system tray will be a dark grey. Maximize the browser. The tray should be a lighter grey. This will mimic the colour changes of the application launcher on the shelf.
BUG=378115
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274318

[flackr, 2014-05-30 15:42:14]

Looks reasonable to me, add a TEST= line describing briefly how to manually
verify this.

https://codereview.chromium.org/302153002/diff/1/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/302153002/diff/1/ash/shelf/shelf_widget.cc#ne...
ash/shelf/shelf_widget.cc:721: status_area_widget_->ShelfDimChanged();
Maybe this should just be called SchedulePaint, and it can call SchedulePaint on
its ContentsView if necessary.

[jonross, 2014-05-30 15:56:06]

https://codereview.chromium.org/302153002/diff/1/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/302153002/diff/1/ash/shelf/shelf_widget.cc#ne...
ash/shelf/shelf_widget.cc:721: status_area_widget_->ShelfDimChanged();
On 2014/05/30 15:42:15, flackr wrote:
> Maybe this should just be called SchedulePaint, and it can call SchedulePaint
on
> its ContentsView if necessary.

Done.

[flackr, 2014-05-30 18:13:19]

lgtm, it might be worth renaming to SchedulePaintOnChildLayers or something to
be clear that it's not scheduling paint on itself, but I defer to the owner you
add to the review on that.

[jonross, 2014-05-30 18:19:51]

+oshima for owners review.

@flackr I didn't name it SchedulePaintOnChildLayers in the first pass as
status_area_widget_delegate_ came across more as a mirror object than a child.

In reality the delegate is the actual parent view of the trays.

[oshima, 2014-05-31 15:10:36]

https://codereview.chromium.org/302153002/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (left):

https://codereview.chromium.org/302153002/diff/20001/ash/shelf/shelf_widget.c...
ash/shelf/shelf_widget.cc:720:
status_area_widget_->GetContentsView()->SchedulePaint();
won't GetNativeView()->SchedulePaintInRect() work?

(not sure why Window::SchedulePaint() is private. you may want to ask owners if
it can be public)

[jonross, 2014-06-02 14:57:09]

https://codereview.chromium.org/302153002/diff/20001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (left):

https://codereview.chromium.org/302153002/diff/20001/ash/shelf/shelf_widget.c...
ash/shelf/shelf_widget.cc:720:
status_area_widget_->GetContentsView()->SchedulePaint();
On 2014/05/31 15:10:36, oshima wrote:
> won't GetNativeView()->SchedulePaintInRect() work?
> 
> (not sure why Window::SchedulePaint() is private. you may want to ask owners
if
> it can be public)

That call does not work. It also finds the current layer, and does not notify
the child layers.

[oshima, 2014-06-02 17:22:54]

On 2014/06/02 14:57:09, jonross wrote:
> https://codereview.chromium.org/302153002/diff/20001/ash/shelf/shelf_widget.cc
> File ash/shelf/shelf_widget.cc (left):
> 
>
https://codereview.chromium.org/302153002/diff/20001/ash/shelf/shelf_widget.c...
> ash/shelf/shelf_widget.cc:720:
> status_area_widget_->GetContentsView()->SchedulePaint();
> On 2014/05/31 15:10:36, oshima wrote:
> > won't GetNativeView()->SchedulePaintInRect() work?
> > 
> > (not sure why Window::SchedulePaint() is private. you may want to ask owners
> if
> > it can be public)
> 
> That call does not work. It also finds the current layer, and does not notify
> the child layers.

AH you're right, nvm. lgtm

[jonross, 2014-06-02 17:24:25]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2014-06-02 17:25:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jonross@chromium.org/302153002/20001

[commit-bot: I haz the power, 2014-06-02 20:37:50]

Change committed as 274318