Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 3021433002: [Telemetry] Make `run_benchmark list` support SUPPORTED_PLATFORMS and StoryExpectations. (Closed)

Created:
3 years, 2 months ago by rnephew (Reviews Here)
Modified:
3 years, 2 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Make `run_benchmark list` support SUPPORTED_PLATFORMS and StoryExpectations. Before it was only using decorators to mark benchmarks as disabled. BUG=chromium:713222 Review-Url: https://chromiumcodereview.appspot.com/3021433002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cf05c91b67574954c0f62d369077943f04f5de07

Patch Set 1 #

Patch Set 2 : Move back to function #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -48 lines) Patch
M telemetry/telemetry/benchmark_runner.py View 1 1 chunk +12 lines, -3 lines 0 comments Download
M telemetry/telemetry/benchmark_runner_unittest.py View 3 chunks +50 lines, -45 lines 2 comments Download

Messages

Total messages: 14 (9 generated)
rnephew (Reviews Here)
3 years, 2 months ago (2017-09-25 22:03:16 UTC) #3
nednguyen
lgtm https://codereview.chromium.org/3021433002/diff/20001/telemetry/telemetry/benchmark_runner_unittest.py File telemetry/telemetry/benchmark_runner_unittest.py (right): https://codereview.chromium.org/3021433002/diff/20001/telemetry/telemetry/benchmark_runner_unittest.py#newcode93 telemetry/telemetry/benchmark_runner_unittest.py:93: BenchmarkDisabled.ShouldDisable = FakeShouldDisable Are we also gonna remove ...
3 years, 2 months ago (2017-09-26 15:17:30 UTC) #8
rnephew (Reviews Here)
https://codereview.chromium.org/3021433002/diff/20001/telemetry/telemetry/benchmark_runner_unittest.py File telemetry/telemetry/benchmark_runner_unittest.py (right): https://codereview.chromium.org/3021433002/diff/20001/telemetry/telemetry/benchmark_runner_unittest.py#newcode93 telemetry/telemetry/benchmark_runner_unittest.py:93: BenchmarkDisabled.ShouldDisable = FakeShouldDisable On 2017/09/26 15:17:30, nednguyen wrote: > ...
3 years, 2 months ago (2017-09-26 15:55:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3021433002/20001
3 years, 2 months ago (2017-09-26 15:55:26 UTC) #11
commit-bot: I haz the power
3 years, 2 months ago (2017-09-26 15:57:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698