Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 302143003: Docserver: Make API features inherit 'channel' from their dependencies (Closed)

Created:
6 years, 6 months ago by not at google - send to devlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, danielj41
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Docserver: Make API features inherit 'channel' from their dependencies (manifest or permission features). This fixes the availability data on accessibilityFeatures and bluetoothLowEnergy, among others; anywhere the API and dependency name differ. BUG=375615 R=rockot@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273935

Patch Set 1 #

Patch Set 2 : another test, cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -13 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/features_bundle.py View 1 4 chunks +19 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/features_bundle_test.py View 1 10 chunks +58 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
not at google - send to devlin
danielj41 - FYI
6 years, 6 months ago (2014-05-30 15:35:50 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 6 months ago (2014-05-30 16:12:35 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-05-30 16:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/302143003/10001
6 years, 6 months ago (2014-05-30 16:41:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 22:19:15 UTC) #5
not at google - send to devlin
The CQ bit was unchecked by kalman@chromium.org
6 years, 6 months ago (2014-05-30 23:24:17 UTC) #6
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-05-30 23:24:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/302143003/10001
6 years, 6 months ago (2014-05-30 23:30:18 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 23:35:27 UTC) #9
Message was sent while issue was closed.
Change committed as 273935

Powered by Google App Engine
This is Rietveld 408576698