Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: Source/core/page/EventHandler.cpp

Issue 302133002: Fix a document memory leak in drag-and-drop. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed the comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/clipboard/Clipboard.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 3019 matching lines...) Expand 10 before | Expand all | Expand 10 after
3030 break; 3030 break;
3031 case DragSourceActionNone: 3031 case DragSourceActionNone:
3032 ASSERT_NOT_REACHED(); 3032 ASSERT_NOT_REACHED();
3033 } 3033 }
3034 3034
3035 return abs(delta.width()) >= threshold || abs(delta.height()) >= threshold; 3035 return abs(delta.width()) >= threshold || abs(delta.height()) >= threshold;
3036 } 3036 }
3037 3037
3038 void EventHandler::freeClipboard() 3038 void EventHandler::freeClipboard()
3039 { 3039 {
3040 if (dragState().m_dragClipboard) 3040 if (dragState().m_dragClipboard) {
3041 dragState().m_dragClipboard->clearDragImage();
3041 dragState().m_dragClipboard->setAccessPolicy(ClipboardNumb); 3042 dragState().m_dragClipboard->setAccessPolicy(ClipboardNumb);
3043 }
3042 } 3044 }
3043 3045
3044 void EventHandler::dragSourceEndedAt(const PlatformMouseEvent& event, DragOperat ion operation) 3046 void EventHandler::dragSourceEndedAt(const PlatformMouseEvent& event, DragOperat ion operation)
3045 { 3047 {
3046 // Send a hit test request so that RenderLayer gets a chance to update the : hover and :active pseudoclasses. 3048 // Send a hit test request so that RenderLayer gets a chance to update the : hover and :active pseudoclasses.
3047 HitTestRequest request(HitTestRequest::Release | HitTestRequest::ConfusingAn dOftenMisusedDisallowShadowContent); 3049 HitTestRequest request(HitTestRequest::Release | HitTestRequest::ConfusingAn dOftenMisusedDisallowShadowContent);
3048 prepareMouseEvent(request, event); 3050 prepareMouseEvent(request, event);
3049 3051
3050 if (dragState().m_dragSrc) { 3052 if (dragState().m_dragSrc) {
3051 dragState().m_dragClipboard->setDestinationOperation(operation); 3053 dragState().m_dragClipboard->setDestinationOperation(operation);
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
3731 unsigned EventHandler::accessKeyModifiers() 3733 unsigned EventHandler::accessKeyModifiers()
3732 { 3734 {
3733 #if OS(MACOSX) 3735 #if OS(MACOSX)
3734 return PlatformEvent::CtrlKey | PlatformEvent::AltKey; 3736 return PlatformEvent::CtrlKey | PlatformEvent::AltKey;
3735 #else 3737 #else
3736 return PlatformEvent::AltKey; 3738 return PlatformEvent::AltKey;
3737 #endif 3739 #endif
3738 } 3740 }
3739 3741
3740 } // namespace WebCore 3742 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/clipboard/Clipboard.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698