LayoutTests/fast/events/drag-leak-document.html - Issue 302133002: Fix a document memory leak in drag-and-drop.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/drag-leak-document.html

Issue 302133002: Fix a document memory leak in drag-and-drop. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: ready Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>
	haraken 2014/06/02 02:24:17 Nit: We normally write a <script> tag in <body>. Nit: We normally write a <script> tag in <body>. Dai Mikurube (NOT FULLTIME) 2014/06/02 03:11:51 Done. Show quoted text On 2014/06/02 02:24:17, haraken wrote: > > Nit: We normally write a <script> tag in <body>. Done.
	5 if (window.testRunner) {

	6 testRunner.waitUntilDone();
	haraken 2014/06/02 02:24:17 This test doesn't need to be async, so waitUntilDo This test doesn't need to be async, so waitUntilDone is not needed. Dai Mikurube (NOT FULLTIME) 2014/06/02 03:11:51 Done. Show quoted text On 2014/06/02 02:24:17, haraken wrote: > > This test doesn't need to be async, so waitUntilDone is not needed. Done.
	7 testRunner.dumpAsText();

	8 }

	9 function runTest() {

	10 var draggedElement = document.getElementById('draggedElement');

	11 var x = draggedElement.offsetLeft + draggedElement.offsetWidth / 2;

	12 var y = draggedElement.offsetTop + draggedElement.offsetHeight / 2;

	13

	14 eventSender.mouseMoveTo(x, y);

	15 eventSender.mouseDown();

	16 eventSender.mouseMoveTo(x + 100, y + 100);

	17 eventSender.mouseUp();

	18 testRunner.notifyDone();
	haraken 2014/06/02 02:24:17 Remove this. Remove this. Dai Mikurube (NOT FULLTIME) 2014/06/02 03:11:51 Done. Show quoted text On 2014/06/02 02:24:17, haraken wrote: > > Remove this. Done.
	19 }

	20 </script>

	21 </head>

	22 <body onload="runTest()">

	23 <div id="draggedElement" draggable="true">Drag</div>

	24 <p>PASS if no leak is detected by the leak detector.</p>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/drag-leak-document-expected.txt » ('j') | no next file with comments »