Source/platform/graphics/media/MediaPlayer.cpp - Issue 302093011: Oilpan: move the MediaPlayer and MediaPlayerClient objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/media/MediaPlayer.cpp

Issue 302093011: Oilpan: move the MediaPlayer and MediaPlayerClient objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have MediaController weakly track its media elements Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/media/MediaPlayer.h ('K') | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/platform/heap/Handle.h » ('j') | Source/web/WebMediaPlayerClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/media/MediaPlayer.cpp

diff --git a/Source/platform/graphics/media/MediaPlayer.cpp b/Source/platform/graphics/media/MediaPlayer.cpp

index e86d08a8b9a87a7f3179b6c00628d4a95389f5b1..b19f01966603652aab467c67f0dc274cd75f2029 100644

--- a/Source/platform/graphics/media/MediaPlayer.cpp

+++ b/Source/platform/graphics/media/MediaPlayer.cpp

@@ -39,7 +39,7 @@ void MediaPlayer::setMediaEngineCreateFunction(CreateMediaEnginePlayer createFun

createMediaEngineFunction = createFunction;

}

-PassOwnPtr<MediaPlayer> MediaPlayer::create(MediaPlayerClient* client)

+PassOwnPtrWillBeRawPtr<MediaPlayer> MediaPlayer::create(MediaPlayerClient* client)

{

ASSERT(createMediaEngineFunction);

return createMediaEngineFunction(client);