Oilpan: move the MediaPlayer and MediaPlayerClient objects to the heap.

Source/platform/graphics/media/MediaPlayer.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef MediaPlayer_h
 #define MediaPlayer_h
 
 #include "platform/PlatformExport.h"
 #include "platform/graphics/GraphicsTypes3D.h"
+#include "platform/heap/Handle.h"
 #include "public/platform/WebMediaPlayer.h"
 #include "wtf/Forward.h"
 #include "wtf/Noncopyable.h"
 
 namespace blink {
 class WebGraphicsContext3D;
 class WebContentDecryptionModule;
 class WebInbandTextTrack;
 class WebLayer;
 class WebMediaSource;
 }
 
 namespace WebCore {
 
 class AudioSourceProvider;
 class GraphicsContext;
 class IntRect;
 class KURL;
 class MediaPlayer;
 class TimeRanges;
 
 // GL types as defined in OpenGL ES 2.0 header file gl2.h from khronos.org.
 // That header cannot be included directly due to a conflict with NPAPI headers.
 // See crbug.com/328085.
 typedef unsigned GC3Denum;
 typedef int GC3Dint;
 
-class MediaPlayerClient {
+class MediaPlayerClient : public WillBeGarbageCollectedMixin {

[sof, 2014/06/02 11:36:28]

The use of DummyBase<void> breaks the component build in the non-Oilpan case,
see
http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...

I _thought_ this was due to DummyBase being provided via WebCore & moved it to
WTF instead, but no. I've not yet #if-ed my way around the issue..is there a
better way to handle it?

 public:
     virtual ~MediaPlayerClient() { }
 
+    virtual void trace(Visitor*) { }
+
     // the network state has changed
     virtual void mediaPlayerNetworkStateChanged() = 0;
 
     // the ready state has changed
     virtual void mediaPlayerReadyStateChanged() = 0;
 
     // time has jumped, eg. not as a result of normal playback
     virtual void mediaPlayerTimeChanged() = 0;
 
     // the media file duration has changed, or is now known
@@ skipping 18 matching lines @@
     virtual void mediaPlayerSizeChanged() = 0;
 
     virtual void mediaPlayerSetWebLayer(blink::WebLayer*) = 0;
 
     virtual void mediaPlayerDidAddTextTrack(blink::WebInbandTextTrack*) = 0;
     virtual void mediaPlayerDidRemoveTextTrack(blink::WebInbandTextTrack*) = 0;
 
     virtual void mediaPlayerMediaSourceOpened(blink::WebMediaSource*) = 0;
 };
 
-typedef PassOwnPtr<MediaPlayer> (*CreateMediaEnginePlayer)(MediaPlayerClient*);
+typedef PassOwnPtrWillBeRawPtr<MediaPlayer> (*CreateMediaEnginePlayer)(MediaPlayerClient*);
 
-class PLATFORM_EXPORT MediaPlayer {
+class PLATFORM_EXPORT MediaPlayer : public WillBeGarbageCollectedMixin {
     WTF_MAKE_NONCOPYABLE(MediaPlayer);
 public:
-    static PassOwnPtr<MediaPlayer> create(MediaPlayerClient*);
+    static PassOwnPtrWillBeRawPtr<MediaPlayer> create(MediaPlayerClient*);
     static void setMediaEngineCreateFunction(CreateMediaEnginePlayer);
 
     static double invalidTime() { return -1.0; }
 
     MediaPlayer() { }
     virtual ~MediaPlayer() { }
 
+    virtual void trace(Visitor*) { }
+
+    virtual void detach() = 0;
+
     virtual void load(blink::WebMediaPlayer::LoadType, const String& url, blink::WebMediaPlayer::CORSMode) = 0;
 
     virtual void play() = 0;
     virtual void pause() = 0;
 
     virtual bool supportsSave() const = 0;
 
     virtual double duration() const = 0;
 
     virtual double currentTime() const = 0;
@@ skipping 34 matching lines @@
 
 #if ENABLE(WEB_AUDIO)
     virtual AudioSourceProvider* audioSourceProvider() = 0;
 #endif
     virtual blink::WebMediaPlayer* webMediaPlayer() const = 0;
 };
 
 }
 
 #endif // MediaPlayer_h