Source/platform/graphics/media/MediaPlayer.cpp - Issue 302093011: Oilpan: move the MediaPlayer and MediaPlayerClient objects to the heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/graphics/media/MediaPlayer.cpp

Issue 302093011: Oilpan: move the MediaPlayer and MediaPlayerClient objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move DummyBase from WebCore to WTF Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/platform/graphics/media/MediaPlayer.h ('K') | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/platform/heap/Handle.h » ('j') | Source/platform/heap/Handle.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 21 matching lines...) Expand all Loading...
32	32

33 static CreateMediaEnginePlayer createMediaEngineFunction = 0;	33 static CreateMediaEnginePlayer createMediaEngineFunction = 0;

34	34

35 void MediaPlayer::setMediaEngineCreateFunction(CreateMediaEnginePlayer createFun ction)	35 void MediaPlayer::setMediaEngineCreateFunction(CreateMediaEnginePlayer createFun ction)

36 {	36 {

37 ASSERT(createFunction);	37 ASSERT(createFunction);

38 ASSERT(!createMediaEngineFunction);	38 ASSERT(!createMediaEngineFunction);

39 createMediaEngineFunction = createFunction;	39 createMediaEngineFunction = createFunction;

40 }	40 }

41	41

42 PassOwnPtr<MediaPlayer> MediaPlayer::create(MediaPlayerClient* client)	42 PassOwnPtrWillBeRawPtr<MediaPlayer> MediaPlayer::create(MediaPlayerClient* clien t)

43 {	43 {

44 ASSERT(createMediaEngineFunction);	44 ASSERT(createMediaEngineFunction);

45 return createMediaEngineFunction(client);	45 return createMediaEngineFunction(client);

46 }	46 }

47	47

48 } // namespace WebCore	48 } // namespace WebCore

OLD	NEW