Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 302093009: Linux: Unify udev scopers. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -147 lines) Patch
M components/storage_monitor.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M components/storage_monitor/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/storage_monitor/udev_util_linux.h View 1 chunk +0 lines, -13 lines 0 comments Download
M components/storage_monitor/udev_util_linux.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M device/hid/device_monitor_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M device/hid/hid_connection_linux.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/hid/hid_service_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D device/hid/udev_common.h View 1 chunk +0 lines, -49 lines 0 comments Download
A device/udev_linux/udev.h View 1 chunk +38 lines, -0 lines 0 comments Download
A device/udev_linux/udev.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A device/udev_linux/udev.gyp View 1 1 chunk +30 lines, -0 lines 0 comments Download
A ui/events/ozone/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/device/device_manager.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 5 chunks +8 lines, -7 lines 0 comments Download
D ui/events/ozone/device/udev/scoped_udev.h View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
6 years, 6 months ago (2014-05-31 09:43:47 UTC) #1
ygorshenin1
lgtm
6 years, 6 months ago (2014-06-02 12:23:31 UTC) #2
spang
lgtm
6 years, 6 months ago (2014-06-02 17:03:02 UTC) #3
Lei Zhang
+rockot for device/OWNERS
6 years, 6 months ago (2014-06-02 21:44:58 UTC) #4
Ken Rockot(use gerrit already)
LGTM! Thanks for doing this.
6 years, 6 months ago (2014-06-02 22:15:43 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-03 19:23:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/302093009/20001
6 years, 6 months ago (2014-06-03 19:24:36 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 22:36:09 UTC) #8
Message was sent while issue was closed.
Change committed as 274658

Powered by Google App Engine
This is Rietveld 408576698