Add devtools resources rules to the GN build.

Add devtools resources rules to the GN build.

This should duplicate the devtools resources, with the exception of the "debug" build of devtools.

R=apavlov@chromium.org, jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175501

[brettw, 2014-05-30 23:32:26]

Note that this requires https://codereview.chromium.org/305013009/

[jamesr, 2014-05-31 00:49:35]

apavlov@ seems to have worked on the devtools gyp stuff lately, maybe he'd be a
good reviewer?  There's a lot in here new to me but I'll try to read through it
too.

[apavlov, 2014-06-02 18:51:34]

Hey Brett,

Is this going to be finished before the final switch to GN? debug_devtools=1 is
the primary mode for all devtools developers.

[brettw, 2014-06-02 19:23:03]

On 2014/06/02 18:51:34, apavlov wrote:
> Hey Brett,
> 
> Is this going to be finished before the final switch to GN? debug_devtools=1
is
> the primary mode for all devtools developers.

The GYP build will be in parallel to the GN build for the time being. There will
be plenty of time to sort out the flags and what's supported.

[apavlov, 2014-06-03 08:16:06]

Thanks Brett, that sounds comforting :) LGTM

[apavlov, 2014-06-03 10:07:05]

+OWNERS

[jamesr, 2014-06-03 15:40:49]

public lgtm

[apavlov, 2014-06-03 16:29:34]

@brettw: FYI, now that https://codereview.chromium.org/283063003/ has landed,
you need to actually implement the "build_settings_module" target for the
debug_devtools==0 case

[jamesr, 2014-06-04 06:14:13]

https://codereview.chromium.org/302093008/diff/40001/Source/devtools/BUILD.gn
File Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/302093008/diff/40001/Source/devtools/BUILD.gn...
Source/devtools/BUILD.gn:57: visibility = "//third_party/WebKit/*"
the general convention for third_party/WebKit is that only stuff in
third_party/WebKit/public/ should be referenced by anything outside of the blink
repository. should we be enforcing this with visibility directives in all
BUILD.gn's? seems a lil' strange to have it just in this one

https://codereview.chromium.org/302093008/diff/40001/Source/devtools/BUILD.gn...
Source/devtools/BUILD.gn:93: # 'copies': [{
is this just

copy("devtools_frontend_resources_copy") {
  sources = gypi_values.devtools_image_files
  outputs = [ [$root_gen_dir/resources/inspector/Images{{source_file_part}}" ]
}

?

[brettw, 2014-06-04 16:54:32]

https://codereview.chromium.org/302093008/diff/40001/Source/devtools/BUILD.gn
File Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/302093008/diff/40001/Source/devtools/BUILD.gn...
Source/devtools/BUILD.gn:57: visibility = "//third_party/WebKit/*"
On 2014/06/04 06:14:13, jamesr wrote:
> the general convention for third_party/WebKit is that only stuff in
> third_party/WebKit/public/ should be referenced by anything outside of the
blink
> repository. should we be enforcing this with visibility directives in all
> BUILD.gn's? seems a lil' strange to have it just in this one

Yeah, we should do this.

https://codereview.chromium.org/302093008/diff/40001/Source/devtools/BUILD.gn...
Source/devtools/BUILD.gn:93: # 'copies': [{
Yes, added.

[brettw, 2014-06-04 18:13:20]

Committed patchset #4 manually as r175501.