Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 302093002: Remove scheduleLayerUpdate from RenderLayerCompositor. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1, Ian Vollick, Julien - ping for review
Visibility:
Public.

Description

Remove scheduleLayerUpdate from RenderLayerCompositor. Now that frames always have a layer and get their self-painting bit updated whenever m_compositing changes, we don't need to do a layer update when they get composited. Instead we just need to mark the frame in the owner page as needing a compositing update. This removes one of the needs for applyUpdateLayerCompositingStateChickenEggHacks. BUG=379097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175505

Patch Set 1 #

Patch Set 2 : remove unneeded assert disabler #

Patch Set 3 : remove offending code #

Patch Set 4 : merge to ToT #

Patch Set 5 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -97 lines) Patch
M Source/core/core.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
D Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp View 1 1 chunk +0 lines, -31 lines 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 3 4 5 chunks +7 lines, -35 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ojan
This depends on https://codereview.chromium.org/302083002/.
6 years, 6 months ago (2014-05-30 00:00:11 UTC) #1
ojan
Hmmm...removing the disabler was premature. I'll upload a new patch that doesn't do that.
6 years, 6 months ago (2014-05-30 00:01:32 UTC) #2
ojan
Nope. It wasn't that. We're hitting the assert I added last week when I asserted ...
6 years, 6 months ago (2014-05-30 00:32:28 UTC) #3
ojan
OK. I think the new patch I have up for review is correct. It was ...
6 years, 6 months ago (2014-06-03 03:07:01 UTC) #4
ojan
Oh. Ugh. The trybot won't work since this patch depends on https://codereview.chromium.org/302083002/. Lets get https://codereview.chromium.org/302083002/ ...
6 years, 6 months ago (2014-06-03 03:07:56 UTC) #5
esprehn
lgtm, this is amazing.
6 years, 6 months ago (2014-06-03 20:20:53 UTC) #6
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-04 03:57:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/302093002/50001
6 years, 6 months ago (2014-06-04 03:57:56 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 05:00:45 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 05:08:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10210)
6 years, 6 months ago (2014-06-04 05:08:11 UTC) #11
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-04 17:10:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/302093002/70001
6 years, 6 months ago (2014-06-04 17:11:23 UTC) #13
ojan
The CQ bit was unchecked by ojan@chromium.org
6 years, 6 months ago (2014-06-04 17:47:07 UTC) #14
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-04 17:47:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/302093002/70001
6 years, 6 months ago (2014-06-04 17:47:19 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 18:41:29 UTC) #17
Message was sent while issue was closed.
Change committed as 175505

Powered by Google App Engine
This is Rietveld 408576698