Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 302083016: Adding additional packages for nacl and naclports to install-build-deps.sh (Closed)

Created:
6 years, 6 months ago by bradn
Modified:
6 years, 6 months ago
Reviewers:
Sam Clegg, hinoka
CC:
chromium-reviews
Visibility:
Public.

Description

Adding additional packages for nacl and naclports to install-build-deps.sh Adds about 40MB. BUG=None TEST=local R=sbc@chromium.org, hinoka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274362

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M build/install-build-deps.sh View 3 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bradn
6 years, 6 months ago (2014-06-02 19:24:28 UTC) #1
Sam Clegg
https://codereview.chromium.org/302083016/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/302083016/diff/1/build/install-build-deps.sh#newcode154 build/install-build-deps.sh:154: libexif12:i386 libgl1-mesa-glx:i386" What happens when this runs on a ...
6 years, 6 months ago (2014-06-02 19:26:01 UTC) #2
bradn
https://codereview.chromium.org/302083016/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/302083016/diff/1/build/install-build-deps.sh#newcode154 build/install-build-deps.sh:154: libexif12:i386 libgl1-mesa-glx:i386" On 2014/06/02 19:26:01, Sam Clegg wrote: > ...
6 years, 6 months ago (2014-06-02 19:38:42 UTC) #3
Sam Clegg
On 2014/06/02 19:38:42, bradn wrote: > https://codereview.chromium.org/302083016/diff/1/build/install-build-deps.sh > File build/install-build-deps.sh (right): > > https://codereview.chromium.org/302083016/diff/1/build/install-build-deps.sh#newcode154 > ...
6 years, 6 months ago (2014-06-02 20:25:09 UTC) #4
bradn
I tried on a build slave.
6 years, 6 months ago (2014-06-02 20:32:59 UTC) #5
bradn
The CQ bit was checked by bradnelson@google.com
6 years, 6 months ago (2014-06-02 20:33:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/302083016/1
6 years, 6 months ago (2014-06-02 20:34:03 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 21:50:32 UTC) #8
bradn
The CQ bit was checked by bradnelson@google.com
6 years, 6 months ago (2014-06-02 23:09:23 UTC) #9
bradn
The CQ bit was unchecked by bradnelson@google.com
6 years, 6 months ago (2014-06-02 23:09:32 UTC) #10
bradn
6 years, 6 months ago (2014-06-02 23:10:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 manually as r274362 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698