Issue 302083009: Revert of Enable a srcset 0x descriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302083009: Revert of Enable a srcset 0x descriptor (Closed)

Created:
6 years, 6 months ago by Yoav Weiss

Modified:
6 years, 6 months ago

Reviewers:
pdr., eseidel

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Revert of Enable a srcset 0x descriptor (https://codereview.chromium.org/305643006/) Reason for revert: This patch closed the tree with a '"update" on "Win7 Tests"' message. Reverting Original issue's description: > Enable a srcset 0x descriptor > > According to recent spec changes, a "0x" descriptor should be correctly parsed, > and imply intrinsic dimensions of infinity to the image. > This CL enables that, and tests that intrinsic dimensions are impacted accordingly. > > BUG=378252 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175196 TBR=eseidel@chromium.org,pdr@chromium.org NOTREECHECKS=true NOTRY=true BUG=378252 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175197

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -49 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/hidpi/image-srcset-intrinsic-size.html	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	LayoutTests/fast/hidpi/image-srcset-intrinsic-size-expected.txt	View	1 chunk	+4 lines, -6 lines	0 comments	Download
D	LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero.html	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero-expected.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLImageElement.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/parser/HTMLSrcsetParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/302083009/1

6 years, 6 months ago (2014-05-31 10:55:56 UTC) #2

Message was sent while issue was closed.

Change committed as 175197