Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 302083007: Set allow_new_privs when launching CRD host controller from the NM process. (Closed)

Created:
6 years, 6 months ago by Sergey Ulanov
Modified:
6 years, 6 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org, jln (very slow on Chromium)
Visibility:
Public.

Description

Set allow_new_privs when launching CRD host controller from the NM process. Previously no_new_prevs mode was used when starting CRD host from NM. This prevents sudo from working properly. r273785 fixed similar problem for the code that launched NM binaries within chrome. BUG=378012 R=lambroslambrou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273983

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
jln@, FYI. This change doesn't affect Chrome of Chrome OS.
6 years, 6 months ago (2014-05-31 00:38:45 UTC) #1
Lambros
LGTM Any other usages of base::LaunchProcess we need to check? https://codereview.chromium.org/302083007/diff/1/remoting/host/setup/daemon_controller_delegate_linux.cc File remoting/host/setup/daemon_controller_delegate_linux.cc (right): https://codereview.chromium.org/302083007/diff/1/remoting/host/setup/daemon_controller_delegate_linux.cc#newcode106 ...
6 years, 6 months ago (2014-05-31 00:42:20 UTC) #2
Sergey Ulanov
> Any other usages of base::LaunchProcess we need to check? No, this is the only ...
6 years, 6 months ago (2014-05-31 00:45:32 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 6 months ago (2014-05-31 00:45:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/302083007/20001
6 years, 6 months ago (2014-05-31 00:54:18 UTC) #5
Sergey Ulanov
6 years, 6 months ago (2014-05-31 01:39:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r273983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698